-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epub Right to left fixed layout navigation cannot turn to next page when in landscape mode #415
Comments
These are Epub.js bugs (it only happens in more recent versions of Epub.js; the version used on their website is outdated). About the second point, I did notice this with fixed layout books; see futurepress/epub.js#927 (comment). Not sure why navigation is broken, but probably due to the same PR. |
As you said maybe they haven't update their testing version on their website yet. I tried opening epub on https://futurepress.github.io/epub.js/examples/input.html and the |
The release builds are available on jsDelivr: https://cdn.jsdelivr.net/npm/epubjs/dist/, which is convenient when quickly testing the released versions. To build it yourself, clone Epub.js's repo and run |
Tracked down some of the bugs in epub and reported 2 issues related to this futurepress/epub.js#1069 and futurepress/epub.js#1070 but looks like it is no easy fix ... it's related to how epub process books and probably will need some big overhaul to incorporate rtl book flows. |
@johnfactotum I did some really dirty hack to epub.js to make the RTL fixed layout work for me, but no guarantee that it will work on other epubs nor will it break any working epubs. Let me know if you want to take a look and see if you want to incorporate those into foliate before epub.js is fixed properly. |
@hyhchan Can you open a PR to Epub.js? You can add "WIP" in the title or make it a draft if you feel that it's not ready for merging. |
Fixed in the new renderer (#962). |
When reading fixed layout epub that progress from right to left in the landscape mode, the navigation to advance to the next page doesn't work. Pressing right arrow will go back to previous page, and pressing left arrow has no effect. Portrait mode (showing only one page) works.
In the previous version (2.1.2) the navigation in landscape mode works but pressing right arrow will advance while pressing left arrow will go back to previous page (looks like the progression direction was ignored).
Further, when jumping to a particular page (say by entering the page number or selecting a chapter mark that links to an odd number page) the page will always shown on the right side. And then the pages afterwards will be shifted by one page. On Apple books if the chapter mark falls on an odd number page (the page should show up on the left side) the page will render on the right and the previous page (page i-1) will show up on the right side, so the fixed layout moving forward will be preserved.
attached a test epub file that I created to show the issues. The file works as intended on Apple Books app.
test-rtl-epub.zip
Thanks
The text was updated successfully, but these errors were encountered: