fix: install uvx in post-code and post-fix scripts - #843
Conversation
Agent runs were failing when the ty pre-commit hook tried to run type
checking via uvx. The uvx binary wasn't available on GitHub Actions
runners, causing authoritative pre-commit checks to fail with
"Executable 'uvx' not found".
Changes:
- Add UV_VERSION (0.11.14) configuration constant to both scripts
- Install uv/uvx before running pre-commit hooks
- Download and verify uv tarball with SHA256 checksum
- Extract both uv and uvx binaries to ${HOME}/.local/bin
- Add to PATH for pre-commit hook execution
- Follow same pattern as existing gitleaks and lychee installations
- Update section numbering in both scripts (5→6, 6→7, 7→8)
This completes the tooling setup that PR #831 started by adding lychee.
Both lychee (markdown link checking) and uvx (Python tooling via ty hook)
are now installed before pre-commit runs, preventing agent failures.
Related: #830 (pre-commit security), #100 (ty hook configuration)
Builds on: #831 (lychee installation), #783 (markdown link linter)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
fullsend review is working on this — view logs |
Site previewPreview: https://63501432-site.fullsend-ai.workers.dev Commit: |
Review: #843Head SHA: 4f60563 SummaryThe change is well-structured and follows existing installation patterns (gitleaks, lychee) consistently. SHA256 verification, conditional installation guard, and PATH setup are all correct. Two non-blocking findings: the PR body will auto-close issue #100 on merge, but the issue requests removing FindingsMedium
Low
FooterOutcome: comment-only |
|
The code agent run that tested this PR (run 25753770793) failed because the Fix PR: fullsend-ai/.fullsend#31 Once that's merged, agent runs against this PR should pass the |
The script had two sections both numbered 7 ("Process structured
output" and "Iteration-cap warning label") after PR fullsend-ai#843 added
sections without updating subsequent numbers. The header comment
also listed only security layers 1-5 without documenting the
actual script steps 0-8.
Changes:
- Renumber duplicate section 7 to 8, and section 8 to 9
- Update header to separate security layers (now bullet points)
from a new Steps listing that documents all sections 0-9
- Security layers keep their descriptive content but no longer
use numbered format that conflicts with section numbers
Note: make lint could not run in sandbox due to network
restrictions (pre-commit requires external downloads). The
post-script will run the authoritative pre-commit check.
Closes fullsend-ai#962
2 participants
Summary
Completes the pre-commit tooling setup by adding
uvxinstallation to scaffold post-scripts. Agent runs were failing when thetypre-commit hook tried to run Python type checking because uvx wasn't available on GitHub Actions runners.Note: This fix has already been manually applied to the
.fullsendrepo in fullsend-ai/.fullsend#29. This PR updates the scaffold templates so future enrolled repos get the complete tooling setup.Root cause: PR #831 added lychee but didn't address uvx, which is also required by pre-commit hooks (specifically the
tyhook that runs viauvx ty check).Changes:
uvanduvxbinaries to~/.local/binpost-code.shandpost-fix.shin scaffold templatesImpact: This prevents agent run failures where the ty pre-commit hook fails with:
Background: This builds on the tooling setup started in #831 (lychee) and #783 (markdown link linter). Together, these ensure all pre-commit hooks have their required tools available.
Test plan
Related work
🤖 Generated with Claude Code