Skip to content

fix: install lychee in post-code and post-fix scripts - #831

Merged
ralphbean merged 1 commit into
mainfrom
fix/add-lychee-to-post-scripts
May 12, 2026
Merged

ralphbean merged 1 commit into
mainfrom
fix/add-lychee-to-post-scripts

Conversation

@ralphbean

Copy link
Copy Markdown
Member

Summary

Agent runs were failing when pre-commit hooks tried to run lychee for markdown link checking. The lychee binary wasn't available on GitHub Actions runners, causing the authoritative pre-commit check to fail.

Changes

  • Add lychee v0.24.2 installation to post-code.sh and post-fix.sh
  • Download and verify lychee binary before running pre-commit hooks
  • Follow same pattern as existing gitleaks installation
  • Extract to ${HOME}/.local/bin and add to PATH

This ensures the lint-md-links pre-commit hook can execute successfully.

Test plan

  • Verify post-code.sh and post-fix.sh syntax is valid (✅ already verified)
  • Trigger a code agent run and verify pre-commit hooks pass
  • Trigger a fix agent run and verify pre-commit hooks pass

Related

🤖 Generated with Claude Code

Agent runs were failing when pre-commit hooks tried to run lychee for
markdown link checking. The lychee binary wasn't available on GitHub
Actions runners, causing the authoritative pre-commit check to fail.

Changes:
- Add lychee v0.24.2 installation to post-code.sh and post-fix.sh
- Download and verify lychee binary before running pre-commit hooks
- Follow same pattern as existing gitleaks installation
- Extract to ${HOME}/.local/bin and add to PATH

This ensures the lint-md-links pre-commit hook (added in a recent commit)
can execute successfully.

Related: #830 (documents broader security issue with pre-commit hooks
running outside sandbox)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

fullsend review is working on this — view logs

@github-actions

Copy link
Copy Markdown

Site preview

Preview: https://f6d75d36-site.fullsend-ai.workers.dev

Commit: 81412ac1e29d79c009698bf6c34999429699ed7d

@fullsend-ai-review

Copy link
Copy Markdown

Review: #831

Head SHA: 81412ac
Timestamp: 2026-05-12T17:00:00Z
Outcome: approve

Summary

This PR adds lychee v0.24.2 installation to post-code.sh and post-fix.sh so that the lint-md-links pre-commit hook can execute on GitHub Actions runners. The change is a clean tactical fix that follows the established pattern used for gitleaks installation — pinned version, SHA256 hash verification, conditional install via command -v, and extraction to ~/.local/bin. The implementation is correct and appropriately scoped. No security, correctness, or injection concerns.

Findings

Info

  • [style] post-fix.sh:157-170 — Lychee installation runs unconditionally, but pre-commit (which needs it) is guarded by NO_PUSH == false. This means lychee is installed even when there are no commits to push and pre-commit won't run. This mirrors a similar pattern with gitleaks in post-code.sh, so it is consistent within the codebase, but in post-fix.sh specifically, gitleaks is inside the NO_PUSH guard while lychee is not. Minor inconsistency — not blocking.

Footer

Outcome: approve
This review applies to SHA 81412ac1e29d79c009698bf6c34999429699ed7d. Any push to the PR head clears this review and requires a new evaluation.

@ralphbean
ralphbean added this pull request to the merge queue May 12, 2026
Merged via the queue into main with commit d236a60 May 12, 2026
36 checks passed
@ralphbean
ralphbean deleted the fix/add-lychee-to-post-scripts branch May 12, 2026 17:22
ben-alkov pushed a commit to ben-alkov/fullsend that referenced this pull request May 15, 2026
Agent runs were failing when the ty pre-commit hook tried to run type
checking via uvx. The uvx binary wasn't available on GitHub Actions
runners, causing authoritative pre-commit checks to fail with
"Executable 'uvx' not found".

Changes:
- Add UV_VERSION (0.11.14) configuration constant to both scripts
- Install uv/uvx before running pre-commit hooks
- Download and verify uv tarball with SHA256 checksum
- Extract both uv and uvx binaries to ${HOME}/.local/bin
- Add to PATH for pre-commit hook execution
- Follow same pattern as existing gitleaks and lychee installations
- Update section numbering in both scripts (5→6, 6→7, 7→8)

This completes the tooling setup that PR fullsend-ai#831 started by adding lychee.
Both lychee (markdown link checking) and uvx (Python tooling via ty hook)
are now installed before pre-commit runs, preventing agent failures.

Related: fullsend-ai#830 (pre-commit security), fullsend-ai#100 (ty hook configuration)
Builds on: fullsend-ai#831 (lychee installation), fullsend-ai#783 (markdown link linter)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants