Skip to content

docs(#6707): add macOS Apple Silicon caveat for OpenShell 0.0.115 - #6710

Closed
fullsend-ai-coder[bot] wants to merge 4 commits into
mainfrom
agent/6707-openshell-macos-caveat
Closed

docs(#6707): add macOS Apple Silicon caveat for OpenShell 0.0.115#6710
fullsend-ai-coder[bot] wants to merge 4 commits into
mainfrom
agent/6707-openshell-macos-caveat

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Summary

Adds a macOS Apple Silicon caveat to the "Install OpenShell" section of the local-run guide. OpenShell v0.0.115 macOS binaries are broken on Apple Silicon — they are dynamically linked against a Nix store path that only exists on the upstream build host (NVIDIA/OpenShell#2977), causing openshell and openshell-gateway to fail at launch.

The caveat recommends v0.0.113 (which has the same ≥ 0.0.111 lifecycle semantics fullsend requires) and documents the install_name_tool workaround for users who specifically need v0.0.115. Linux binaries and the CI pin are unaffected and unchanged.

Changes

  • Added a blockquote caveat after the install snippet in docs/guides/user/running-agents-locally.md
  • Recommends OPENSHELL_VERSION=0.0.113 for Apple Silicon until the upstream fix ships
  • Documents the install_name_tool + codesign workaround for v0.0.115
  • Scoped for removal once the pin moves past the affected release

Testing

  • Verified no trailing whitespace or EOF issues
  • lint-docs-links passes — no links escape the repo root
  • lychee offline link check passes (0 errors)
  • scan-secrets passes on changed file and staged content
  • gitlint passes on the commit message
  • Docs-only change — no Go/Python code modified, no test suite applicable

Closes #6707

Post-script verification

  • Branch is not main/master (agent/6707-openshell-macos-caveat)
  • Secret scan passed (gitleaks — 96d46c802d4ad44bfea7989835dafb68eeb46195..HEAD)
  • PR body secret scan passed (gitleaks — no-git)

OpenShell 0.0.115 macOS release binaries are dynamically linked
against a Nix store path from the upstream build host
(NVIDIA/OpenShell#2977), causing both openshell and
openshell-gateway to fail at launch on Apple Silicon with a
missing libiconv.2.dylib error. Linux binaries are unaffected.

Add a blockquote caveat to the Install OpenShell section of the
local-run guide recommending v0.0.113 for Apple Silicon users
(which already has the >= 0.0.111 lifecycle semantics fullsend
requires), and documenting the install_name_tool workaround for
users who specifically need v0.0.115. The caveat is scoped for
removal once the pin moves past the affected release.

Closes #6707
@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown

Site preview

Preview: https://2340938c-site.fullsend-ai.workers.dev

Commit: 5d70e5d37ae1e665cd6b1234b89344e18ae3a77f

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 27, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 9:54 PM UTC · Completed 10:07 PM UTC

Commit: af2d64e · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.14

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Aug 27, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 27, 2026

Copy link
Copy Markdown

Risk Assessment: moderate (2/5)

Details

Small additive docs-only change (2 lines) by a trusted bot with all Tier 1 signals at minimum risk; elevated to moderate by very high file churn (29 commits/30d), 7 distinct authors, and 25 fix/revert commits in 90 days on the target file — consistent with prior assessment.

Previous run

Risk Assessment: moderate (2/5)

Details

Small additive docs-only change (2 lines) by a trusted bot with all Tier 1 signals at minimum risk; elevated to moderate by very high file churn (29 commits/30d), 7 distinct authors, and 19 fix/revert commits in 90 days on the target file — consistent with prior assessment.

Previous run (2)

Risk Assessment: moderate (2/5)

Details

Small additive docs-only change by a trusted bot with all Tier 1 signals at minimum risk, but elevated to moderate by unusually high file churn (28 commits/30d), 7 distinct authors, and 9 fix/revert commits in 90 days on the target file.

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review

Findings

Medium

  • [redundant / no-op change] docs/guides/user/running-agents-locally.md:56 — This PR bumps OPENSHELL_VERSION from 0.0.115 to 0.0.116, but main already contains 0.0.116 at this line (landed in commit 5932b2f2). The PR was branched before that commit and is now a no-op — merging it produces no net change. The pin file .github/scripts/openshell-version.sh also already reads 0.0.116, confirming this is fully resolved. Additionally, the linked issue docs: OpenShell 0.0.115 macOS release binaries are Nix-linked and do not start; install guide points Apple Silicon users at it #6707 is already closed.
    Remediation: Close this PR without merging. The underlying issue has already been resolved on main.

Low

  • [PR metadata mismatch] docs/guides/user/running-agents-locally.md:56 — The PR title and body claim to "add macOS Apple Silicon caveat for OpenShell 0.0.115" and "recommend v0.0.113 with install_name_tool workaround," but the actual diff contains none of that — it only bumps the version string from 0.0.115 to 0.0.116. The PR description does not match the diff content, which suggests the branch was force-pushed or rebased after the description was written.
Previous run

Review

Findings

High


Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run (2)

Review

Findings

Low

  • [callout-pattern consistency] docs/guides/user/running-agents-locally.md:61 — The new caveat uses a blockquote prefix (> **macOS Apple Silicon:**) while every other callout in this file uses a bare bold label without a blockquote (**Note**:, **Tip**:). The only other blockquote in the file (line 7) has no bold label at all. This creates a third callout style in the same document.
    Remediation: Either drop the > prefix to match the existing **Note**:/**Tip**: pattern (e.g., **macOS Apple Silicon:** OpenShell 0.0.115...), or convert the other callouts to blockquotes for consistency. The former is the smaller change.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run (3)

Review

Findings

Medium

  • [Internal consistency / edge case] docs/guides/user/running-agents-locally.md:88 — The install_name_tool workaround hardcodes a Homebrew Cellar path ($(brew --prefix)/Cellar/openshell/0.0.115/bin/$b) and uses brew services restart, but the primary installation method documented earlier in this guide uses the curl-based install script (curl -LsSf ... | sh). A user who followed the guide's own curl-based instructions would have binaries at a different location, causing the workaround to fail with a file-not-found error. Consider adding a note that this workaround applies to Homebrew installations, or using $(which openshell) and $(which openshell-gateway) to locate binaries generically.

Low

  • [callout-pattern consistency] docs/guides/user/running-agents-locally.md:78**Workaround** omits the trailing colon that **Recommended:** and the file's other labels (**Tip**:, **Note**:) all include. Add a colon → **Workaround:** for consistency.

fullsend-ai-review[bot]

This comment was marked as outdated.

@rh-hemartin

Copy link
Copy Markdown
Member

/fs-fix reduce the changes to a one line, something like: "on macos use this version because this problem"

@fullsend-ai-coder

fullsend-ai-coder Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Finished Fix · ✅ Success · Started 9:35 AM UTC · Completed 9:40 AM UTC

Commit: af2d64e · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $1.11

Reduce the verbose 34-line blockquote to a single-line note per
reviewer feedback. The one-liner identifies the broken version,
links the upstream issue, and recommends v0.0.113.

Addresses review feedback on #6710
@fullsend-ai-coder

Copy link
Copy Markdown
Contributor Author

🔧 Fix agent — iteration 1 (human-triggered)

Condensed the macOS Apple Silicon caveat from a 34-line blockquote to a single line per reviewer request.

Fixed (1):

  1. reduce the macOS caveat to a one-liner (docs/guides/user/running-agents-locally.md): Replaced the 34-line blockquote caveat with a single line: identifies the broken version (0.0.115), links the upstream issue (ci: build release binaries with Nix NVIDIA/OpenShell#2977), and recommends v0.0.113

Tests: passed

Next steps:

  • /fs-review — request a re-review of the changes
  • /fs-fix <your instruction> — run another fix pass with specific guidance
  • Push commits directly — review re-runs automatically on push
    Updated by fullsend fix agent

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 31, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 9:42 AM UTC · Completed 9:57 AM UTC

Commit: a587958 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.72

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review fullsend-ai-review Bot removed the requires-manual-review Review requires human judgment label Aug 31, 2026
@fullsend-ai-coder

fullsend-ai-coder Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Finished Fix · ✅ Success · Started 9:59 AM UTC · Completed 10:05 AM UTC

Commit: a587958 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $1.37

Remove the `> ` blockquote prefix from the macOS Apple Silicon caveat
so it matches the bare bold-label pattern (`**Note**:`, `**Tip**:`)
used by every other callout in this document.

Addresses review feedback on #6710
@fullsend-ai-coder

Copy link
Copy Markdown
Contributor Author

🔧 Fix agent — iteration 2 (bot-triggered)

Addressed 1 review finding: removed blockquote prefix from macOS caveat to match existing callout style.

Fixed (1):

  1. callout-pattern consistency (docs/guides/user/running-agents-locally.md): Dropped the > blockquote prefix from the macOS Apple Silicon caveat so it matches the bare bold-label pattern (**Note**:, **Tip**:) used by every other callout in this document.

Tests: passed

Next steps:

  • /fs-review — request a re-review of the changes
  • /fs-fix <your instruction> — run another fix pass with specific guidance
  • Push commits directly — review re-runs automatically on push
    Updated by fullsend fix agent

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 31, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:07 AM UTC · Completed 10:21 AM UTC

Commit: 74ecb40 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.16

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-coder

fullsend-ai-coder Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Finished Fix · ✅ Success · Started 10:23 AM UTC · Completed 10:29 AM UTC

Commit: 74ecb40 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $1.68

The guide on main already recommends OpenShell 0.0.116, which ships the
upstream Apple Silicon fix (NVIDIA/OpenShell#3006). Update the version
pin from 0.0.115 to 0.0.116 and remove the now-obsolete macOS Apple
Silicon caveat — users following the current guide will never encounter
the 0.0.115 dynamic-linking issue.

Addresses review feedback on #6710
@fullsend-ai-coder

Copy link
Copy Markdown
Contributor Author

🔧 Fix agent — iteration 3 (bot-triggered)

Addressed 1 high-severity review finding. Strategy change on iteration 3: previous iterations refined the caveat's formatting; this iteration recognizes the caveat is obsolete because main already pins OpenShell 0.0.116 (which fixes the Apple Silicon issue). Updated version pin to 0.0.116 and removed the caveat entirely.

Fixed (1):

  1. documentation content correctness — obsolete Apple Silicon caveat (docs/guides/user/running-agents-locally.md): Updated the OpenShell version pin from 0.0.115 to 0.0.116 (matching current main) and removed the now-obsolete macOS Apple Silicon caveat. The guide on main already recommends 0.0.116, which ships the upstream fix (fix(ci): normalize macOS binary dependencies NVIDIA/OpenShell#3006), making the caveat about 0.0.115 unnecessary and potentially confusing.

Tests: passed

Strategy change: Previous iterations (1-2) addressed formatting concerns (blockquote prefix, condensing). This iteration takes a fundamentally different approach: recognizing the caveat itself is obsolete due to the upstream version bump to 0.0.116 on main.

Decision points
  • Chose to update the version pin and remove the caveat in-place rather than rebasing on main (alternatives: Rebase the branch on current main, Close the PR as obsolete; rationale: Updating the version pin and removing the caveat is the minimal fix that addresses the reviewer's concern. Rebasing would pull in unrelated changes and is outside the fix agent's scope. Closing the PR is a human/post-script decision.)

Next steps:

  • /fs-review — request a re-review of the changes
  • /fs-fix <your instruction> — run another fix pass with specific guidance
  • Push commits directly — review re-runs automatically on push
    Updated by fullsend fix agent

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 31, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:31 AM UTC · Completed 10:46 AM UTC

Commit: 5d70e5d · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.96

@fullsend-ai-review fullsend-ai-review Bot removed the risk/moderate PR risk: moderate label Aug 31, 2026
@fullsend-ai-review
fullsend-ai-review Bot dismissed stale reviews from themself August 31, 2026 10:46

Superseded by updated review

@fullsend-ai-review fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label Aug 31, 2026
@rh-hemartin

Copy link
Copy Markdown
Member

Problem on OpenShell has been addressed

@fullsend-ai-retro

fullsend-ai-retro Bot commented Aug 31, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 12:06 PM UTC · Completed 12:20 PM UTC

Commit: 5d70e5d · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $4.15

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #6710 — docs(#6707): add macOS Apple Silicon caveat for OpenShell 0.0.115

Outcome: PR closed without merging after 4 review cycles, 3 fix cycles, and ~$17 in agent costs. The underlying issue (#6707) had been resolved 3 days earlier via a separate PR (#6737) that bumped OpenShell to v0.0.116.

Timeline

  1. Aug 27 — Issue docs: OpenShell 0.0.115 macOS release binaries are Nix-linked and do not start; install guide points Apple Silicon users at it #6707 filed (broken macOS binaries in OpenShell 0.0.115). Code agent created PR docs(#6707): add macOS Apple Silicon caveat for OpenShell 0.0.115 #6710 with a 34-line workaround caveat. First review found two issues (medium + low).
  2. Aug 28 — Upstream fix shipped in OpenShell v0.0.116. PR chore(deps): update dependency nvidia/openshell to v0.0.116 #6737 bumped the pin on main. Issue docs: OpenShell 0.0.115 macOS release binaries are Nix-linked and do not start; install guide points Apple Silicon users at it #6707 closed.
  3. Aug 31, 09:35 — Human posted /fs-fix on the now-obsolete PR, triggering 3 autonomous fix-review cycles (~$12 in agent costs). The review agent finally detected that main already had v0.0.116 on its 3rd pass. Human closed the PR at 12:04 UTC.

Root Cause

The fix and review agents had no mechanism to check whether the linked issue (#6707, via Closes #6707) was still open. All 5 agent runs on Aug 31 proceeded with substantive work on a PR whose purpose had been fulfilled by a different change path. A single GitHub API call to check the issue state would have short-circuited the entire loop.

Evidence for Existing Issues

  • #2292 (auto-close orphaned agent PRs when linked issue is closed): This is the most impactful existing issue for this scenario. If PR docs(#6707): add macOS Apple Silicon caveat for OpenShell 0.0.115 #6710 had been auto-closed when docs: OpenShell 0.0.115 macOS release binaries are Nix-linked and do not start; install guide points Apple Silicon users at it #6707 was resolved on Aug 28, the human would never have found it open to issue /fs-fix on Aug 31. This PR is direct evidence that orphaned agent PRs accumulate and attract unnecessary work.
  • #902 / #2992 / #3034 (circuit breaker for review-fix loops): After the human's single /fs-fix command, the system ran 3 autonomous review-fix cycles without further human input, accumulating ~$12 on what turned out to be a no-op. A circuit breaker requiring human re-engagement after 1-2 cycles would have limited the blast radius.
  • #3308 / #5750 (fix agent should verify state against base branch): The fix agent never rebased on main, so it missed that v0.0.116 was already pinned. Rebasing as a prerequisite would have surfaced the obsolescence on the first fix iteration.
  • #1647 (code agent should verify linked issue is still open): Covers the same linked-issue-status check mechanism but is scoped to the code agent only. The proposal below extends this to fix and review agents.

What Went Well

  • The review agent eventually detected the obsolescence (iteration 3) by comparing the diff against main — a correct finding even though it came late.
  • The final review correctly recommended closing the PR rather than merging a no-op.
  • The initial code agent PR and first review were appropriate responses to a real, high-priority issue.

Proposals filed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review Triggers review agent dispatch requires-manual-review Review requires human judgment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: OpenShell 0.0.115 macOS release binaries are Nix-linked and do not start; install guide points Apple Silicon users at it

2 participants