chore: update obsolete GitHub Actions to latest major versions - #2457
Conversation
E2E tests did not runThe
See E2E testing guide for details. |
PR Summary by QodoUpdate GitHub Actions to latest major versions (Node 24 readiness) Description
Diagram
High-Level Assessment
Files changed (15)
|
|
🤖 Finished Review · ✅ Success · Started 11:23 AM UTC · Completed 11:36 AM UTC |
Code Review by Qodo
1. Unpinned write-scope actions
|
ReviewFindingsHigh
Low
Previous runReviewFindingsHigh
Low
Previous runReviewFindingsHigh
Low
Labels: PR updates GitHub Actions versions across CI workflow files — maintenance chore touching CI dependencies. Previous runReviewFindingsHigh
Low
Previous run (2)ReviewFindingsHigh
Low
Labels: PR updates GitHub Actions versions across CI workflow files — maintenance chore touching CI dependencies. |
|
|
||
| - name: Download build artifact | ||
| uses: actions/download-artifact@v4 | ||
| uses: actions/download-artifact@v8 |
There was a problem hiding this comment.
[low] api-contract
upload-artifact is bumped to @v7 (site-build.yml) but download-artifact is bumped to @v8 (site-deploy.yml). These actions are independently versioned and likely cross-compatible, but the version skew across the build-deploy artifact handoff pipeline should be verified.
Suggested fix: Verify cross-version compatibility, or align both to the same major version.
Site previewPreview: https://96b6c465-site.fullsend-ai.workers.dev Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
9811649 to
3e12934
Compare
|
🤖 Finished Review · ✅ Success · Started 7:53 AM UTC · Completed 8:03 AM UTC |
- actions/checkout: v4/v6/v6.0.2 → v7 (Node 24, safer pull_request_target defaults) - actions/setup-go: v5 → v6 - actions/upload-artifact: v4 → v7 - actions/download-artifact: v4 → v8 - actions/stale: v9 → v10 - actions/github-script: v8 → v9 - google-github-actions/auth: v2 → v3 (e2e.yml only; setup-gcp already on v3) - sigstore/cosign-installer: v3 → v4 - codecov/codecov-action: v5 → v7 SHA-pinned refs in sandbox-images.yml are left unchanged (deliberate supply-chain pinning for container builds). Node 20 reached EOL April 2026 — v7 of actions/checkout runs on Node 24. Enforcement of Node 24 will be backported to older major versions on July 16, 2026. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Víctor M. Múgica <vmugicag@redhat.com>
3e12934 to
677b366
Compare
|
🤖 Finished Review · ✅ Success · Started 11:59 AM UTC · Completed 12:11 PM UTC |
|
|
||
| - name: Download build artifact | ||
| uses: actions/download-artifact@v4 | ||
| uses: actions/download-artifact@v8 |
There was a problem hiding this comment.
[low] api-contract
upload-artifact is bumped to @v7 in site-build.yml but download-artifact is bumped to @v8 in site-deploy.yml. These actions form a producer-consumer pair for the site artifact across the build-deploy pipeline. The asymmetric major version bump should be verified against the v8 changelog.
Suggested fix: Verify cross-version compatibility, or align both to the same major version.
|
🤖 Finished Retro · ✅ Success · Started 12:21 PM UTC · Completed 12:30 PM UTC |
Retro: PR #2457 — Update obsolete GitHub ActionsThis was a human-authored, purely mechanical PR bumping 15 GitHub Actions workflow files to latest major versions (40 lines changed, all 1:1 version substitutions). The review bot ran 3 times, each time issuing Timeline
Findings already covered by existing issues
These are not re-proposed since they are well-tracked. Novel findingThe review bot flagged Proposals filed
|
actions/checkout@v7 refuses fork PR head checkouts on pull_request_target unless allow-unsafe-pr-checkout is set. The e2e workflow intentionally checks out authorized PR code after the gate job; restore that behavior after the actions version bump in fullsend-ai#2457. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
…te-actions chore: update obsolete GitHub Actions to latest major versions
actions/checkout@v7 refuses fork PR head checkouts on pull_request_target unless allow-unsafe-pr-checkout is set. The e2e workflow intentionally checks out authorized PR code after the gate job; restore that behavior after the actions version bump in fullsend-ai#2457. Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
actions/checkoutfrom v4/v6/v6.0.2 to v7 (Node 24, saferpull_request_targetdefaults)actions/setup-gofrom v5 to v6actions/upload-artifactfrom v4 to v7actions/download-artifactfrom v4 to v8actions/stalefrom v9 to v10actions/github-scriptfrom v8 to v9google-github-actions/authfrom v2 to v3 (e2e.yml only; setup-gcp already on v3)sigstore/cosign-installerfrom v3 to v4codecov/codecov-actionfrom v5 to v7SHA-pinned refs in
sandbox-images.ymlare intentionally left unchanged (supply-chain pinning for container builds).Motivation
Node 20 reached EOL in April 2026.
actions/checkout@v7runs on Node 24 and adds saferpull_request_targetdefaults to prevent pwn request vulnerabilities. GitHub will backport enforcement to older major versions on July 16, 2026 — updating now avoids a forced migration.The
actions/cache/restore@v4Node 20 deprecation warning is also resolved by this PR, since it was triggered transitively byactions/setup-go@v5(now bumped to v6).Test plan
pull_request_targetworkflows (e2e.yml) still check out correctly with v7's new defaults.fullsendrepos still function correctlysandbox-images.ymlare unaffected (SHA-pinned, not changed)Signed-off-by: Víctor M. Múgica vmugicag@redhat.com
🤖 Generated with Claude Code