Add problem areas: Tekton pipeline review, migration path, multi-tenancy - #2
Closed
vdemeester wants to merge 1 commit into
Closed
Add problem areas: Tekton pipeline review, migration path, multi-tenancy#2vdemeester wants to merge 1 commit into
vdemeester wants to merge 1 commit into
Conversation
Add three new problem documents and expand the code review doc with practitioner perspectives: - tekton-pipeline-review.md: Reviewing Tekton task/pipeline definitions as a distinct domain — embedded shell, stringly-typed interfaces, result propagation, trusted task model, cross-cutting concerns - migration-path.md: Phased approach from current human-driven workflow to agent-driven development (observation → shadow → assisted → conditional autonomy → full autonomy) - multi-tenancy.md: How agents understand and preserve tenant isolation boundaries — namespace scoping, build-time isolation, the testing gap - code-review.md: Add sections on heterogeneous codebase problem, what human reviewers actually catch (and miss), and implications for sub-agent context loading
This was referenced Apr 14, 2026
4 tasks
ascerra
added a commit
to ascerra/fullsend
that referenced
this pull request
May 14, 2026
When a human submits a PR and the review agent requests changes, the fix agent no longer auto-triggers. This is now the default behavior for human-authored PRs. Bot-authored PRs (from the code agent) continue to auto-trigger fixes as before. Humans can opt in to the review-fix loop by adding the `fullsend-fix` label to their PR. The existing `/fix` command for manual invocation is unaffected. Changes across all dispatch paths (org-level shim, reusable dispatcher, per-repo scaffold): - Gate fix dispatch on PR author ending in [bot] OR presence of `fullsend-fix` label - Add defense-in-depth check in reusable-fix.yml that verifies PR author and label before running the fix agent E2E tested in ascerra-fullsend-lab org (human-pr-fix-test repo): 1. Human PR, no label (PR fullsend-ai#1) — fix agent SKIPPED ✅ - Review: https://github.com/ascerra-fullsend-lab/.fullsend/actions/runs/25836235094 - Shim skipped dispatch-fix-bot: https://github.com/ascerra-fullsend-lab/human-pr-fix-test/actions/runs/25836370170 2. Human PR, fullsend-fix label (PR fullsend-ai#2) — fix agent auto-triggered ✅ - Review: https://github.com/ascerra-fullsend-lab/.fullsend/actions/runs/25837485822 - Shim dispatched fix: https://github.com/ascerra-fullsend-lab/human-pr-fix-test/actions/runs/25837620440 - Fix agent succeeded: https://github.com/ascerra-fullsend-lab/.fullsend/actions/runs/25837623950 3. Bot PR, no label (PR fullsend-ai#4, author: ascerra-fullsend-lab-coder[bot]) — fix agent auto-triggered ✅ - Code agent created PR: https://github.com/ascerra-fullsend-lab/.fullsend/actions/runs/25838129538 - Review requested changes: https://github.com/ascerra-fullsend-lab/.fullsend/actions/runs/25838396492 - Shim dispatched fix (no label needed): https://github.com/ascerra-fullsend-lab/human-pr-fix-test/actions/runs/25838580565 - Fix agent succeeded: https://github.com/ascerra-fullsend-lab/.fullsend/actions/runs/25838584099 Co-authored-by: Cursor <cursoragent@cursor.com>
ascerra
pushed a commit
to ascerra/fullsend
that referenced
this pull request
May 16, 2026
Medium: - Updated PR description to reflect that pre-existing plan links were removed from README (no longer claims to link agent-execution-environment, vertex-inference-provisioning, and drift-scanner) Low fullsend-ai#2: - Removed "Minimal wrapper pattern" section from plan document as it argues against itself - describes a pattern that requires capabilities that don't exist yet, then recommends removing it Low fullsend-ai#3: - Updated IsURL function comment to note that url.Parse may not set u.User for all userinfo edge cases, advising implementers to consider additional validation if strict userinfo rejection is required Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
ascerra
added a commit
to ascerra/fullsend
that referenced
this pull request
May 16, 2026
When a human submits a PR and the review agent requests changes, the fix agent no longer auto-triggers. This is now the default behavior for human-authored PRs. Bot-authored PRs (from the code agent) continue to auto-trigger fixes as before. Humans can opt in to the review-fix loop by adding the `fullsend-fix` label to their PR. The existing `/fs-fix` command for manual invocation is unaffected — it intentionally bypasses this gate so authorized users can always trigger fix regardless of labels. Changes across dispatch paths (reusable dispatcher, per-repo scaffold): - Gate fix dispatch on PR author ending in [bot] OR presence of `fullsend-fix` label - Add defense-in-depth check in reusable-fix.yml that verifies PR author and label before running the fix agent - Add inline comment clarifying /fs-fix bypass (per review feedback) Note: fullsend.yaml shim no longer needs this gate — upstream refactored it to delegate all routing to the reusable dispatch workflow. E2E tested in ascerra-fullsend-lab org (human-pr-fix-test repo): 1. Human PR, no label (PR fullsend-ai#1) — fix agent SKIPPED - Review: https://github.com/ascerra-fullsend-lab/.fullsend/actions/runs/25836235094 - Shim skipped dispatch-fix-bot: https://github.com/ascerra-fullsend-lab/human-pr-fix-test/actions/runs/25836370170 2. Human PR, fullsend-fix label (PR fullsend-ai#2) — fix agent auto-triggered - Review: https://github.com/ascerra-fullsend-lab/.fullsend/actions/runs/25837485822 - Shim dispatched fix: https://github.com/ascerra-fullsend-lab/human-pr-fix-test/actions/runs/25837620440 - Fix agent succeeded: https://github.com/ascerra-fullsend-lab/.fullsend/actions/runs/25837623950 3. Bot PR, no label (PR fullsend-ai#4, author: ascerra-fullsend-lab-coder[bot]) — fix agent auto-triggered - Code agent created PR: https://github.com/ascerra-fullsend-lab/.fullsend/actions/runs/25838129538 - Review requested changes: https://github.com/ascerra-fullsend-lab/.fullsend/actions/runs/25838396492 - Shim dispatched fix (no label needed): https://github.com/ascerra-fullsend-lab/human-pr-fix-test/actions/runs/25838580565 - Fix agent succeeded: https://github.com/ascerra-fullsend-lab/.fullsend/actions/runs/25838584099 Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced May 26, 2026
Open
4 tasks
3 tasks
This was referenced Jun 10, 2026
Closed
This was referenced Jun 12, 2026
5 tasks
This was referenced Aug 10, 2026
6 tasks
This was referenced Aug 21, 2026
This was referenced Aug 27, 2026
3 tasks
7 tasks
20 tasks
This was referenced Sep 7, 2026
6 tasks
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three new problem documents and practitioner perspective additions to the code review doc.
New problem areas
Tekton Pipeline Review — Reviewing Tekton task/pipeline definitions is a distinct discipline from reviewing application code. Build-definitions is the most critical repo in the org and it's almost entirely Tekton YAML with embedded shell. This doc covers:
Migration Path — How to get from today's workflow to agent-driven development incrementally. Proposes 5 phases:
Includes repo selection criteria, bootstrap requirements, and anti-patterns.
Multi-tenancy — Konflux is multi-tenant. Agents need to understand tenant isolation boundaries to avoid introducing multi-tenancy bugs. Covers:
Additions to existing docs
Code Review — Added two new sections:
Updated README.md and CLAUDE.md to link the new docs.