Skip to content

docs(#2067): add dispatch workflow sync guidance to CLAUDE.md - #2068

Merged
rh-hemartin merged 1 commit into
mainfrom
agent/2067-dispatch-sync-guidance
Jun 10, 2026
Merged

docs(#2067): add dispatch workflow sync guidance to CLAUDE.md#2068
rh-hemartin merged 1 commit into
mainfrom
agent/2067-dispatch-sync-guidance

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Add a new bold-titled paragraph documenting that dispatch.yml and reusable-dispatch.yml must stay in sync, following the same pattern used for the mint function sync guidance. This addresses a documentation gap that caused PR #2048 to miss syncing a jq payload change across the two files.

Note: make lint could not run in sandbox due to Go module cache permission errors. This is a documentation-only change with no Go code modified.


Closes #2067

Post-script verification

  • Branch is not main/master (agent/2067-dispatch-sync-guidance)
  • Secret scan passed (gitleaks — 46eb2347412401912817b8c5e04ebf4b6ce761b2..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

Add a new bold-titled paragraph documenting that
dispatch.yml and reusable-dispatch.yml must stay in
sync, following the same pattern used for the mint
function sync guidance. This addresses a documentation
gap that caused PR #2048 to miss syncing a jq payload
change across the two files.

Note: make lint could not run in sandbox due to Go
module cache permission errors. This is a
documentation-only change with no Go code modified.

Closes #2067
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Site preview

Preview: https://50e53190-site.fullsend-ai.workers.dev

Commit: 38dba6fbead045bb3860b0fc3e9983394beca553

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 9, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 11:48 AM UTC · Completed 11:53 AM UTC
Commit: ba204cb · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

No findings.

The PR adds dispatch workflow sync guidance to CLAUDE.md, following the established pattern used for mint function and mintcore sync guidance. The referenced file paths (internal/scaffold/fullsend-repo/.github/workflows/dispatch.yml and .github/workflows/reusable-dispatch.yml) are verified to exist and do share identical routing logic. The change is correctly scoped to issue #2067 with no scope creep.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Jun 9, 2026
@rh-hemartin
rh-hemartin added this pull request to the merge queue Jun 10, 2026
Merged via the queue into main with commit de576ed Jun 10, 2026
11 checks passed
@rh-hemartin
rh-hemartin deleted the agent/2067-dispatch-sync-guidance branch June 10, 2026 07:07
@fullsend-ai-retro

fullsend-ai-retro Bot commented Jun 10, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 7:08 AM UTC · Completed 7:21 AM UTC
Commit: 4ed6da4 · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #2068 — Add dispatch workflow sync guidance to CLAUDE.md

This was a clean, efficient end-to-end workflow. Issue #2067 (filed by the retro bot from a prior workflow) was triaged in ~3 minutes, coded in ~5 minutes (single clean edit to CLAUDE.md), review-approved in ~6 minutes, and merged after human approval the next day. No rework was needed.

What went well

  • Code agent was focused and efficient: read CLAUDE.md, verified both referenced workflow files exist, made one precise 2-line edit, and committed cleanly.
  • Review agent correctly verified the documentation claims by reading both workflow files and confirming they share routing logic. The approve verdict was appropriate.
  • Zero rework — the code agent got it right on the first attempt.

Minor observations (already tracked)

  • The review agent dispatched 3 parallel sub-agents for a 2-line docs-only change, which is disproportionate. This is already tracked in #1900 ("Review orchestrator: add fast path for trivial docs/prompt-only changes").
  • make lint failed in the sandbox due to Go module cache permissions. Already tracked in #2041.

No new proposals — existing issues adequately cover the improvement opportunities identified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CLAUDE.md guidance for dispatch.yml ↔ reusable-dispatch.yml sync

1 participant