Skip to content

fix(#95): apply bug label for bug-category issues - #96

Merged
rh-hemartin merged 1 commit into
mainfrom
agent/95-bug-label-post-triage
Jul 10, 2026
Merged

fix(#95): apply bug label for bug-category issues#96
rh-hemartin merged 1 commit into
mainfrom
agent/95-bug-label-post-triage

Conversation

@fullsend-ai-coder

@fullsend-ai-coder fullsend-ai-coder Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Split bug out of the combined bug|documentation|performance case branch in the sufficient action handler so that category "bug" explicitly receives the bug label via add_label, matching the deterministic pattern used for the feature category.

Add bug to CONTROL_LABELS so the triage pipeline owns it and agents cannot add or remove it via label_actions.

Test changes:

  • Add sufficient-bug-gets-bug-label test case
  • Add bug to the mock label list
  • Change nonexistent-label test fixture from bug to
    nonexistent-label

Closes #95

Post-script verification

  • Branch is not main/master (agent/95-bug-label-post-triage)
  • Secret scan passed (gitleaks — c1378fcfe6446067abda25481200eea5b3082182..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

@fullsend-ai-coder
fix(#95): apply bug label for bug-category issues
9ee7398 
Split bug out of the combined bug|documentation|performance case
branch in the sufficient action handler so that category "bug"
explicitly receives the bug label via add_label, matching the
deterministic pattern used for the feature category.

Add bug to CONTROL_LABELS so the triage pipeline owns it and
agents cannot add or remove it via label_actions.

Test changes:
- Add sufficient-bug-gets-bug-label test case
- Add bug to the mock label list
- Change nonexistent-label test fixture from bug to
  nonexistent-label

Closes #95
@fullsend-ai-coder
fullsend-ai-coder Bot requested a review from a team as a code owner July 10, 2026 10:11
@rh-hemartin

rh-hemartin commented Jul 10, 2026

Copy link
Copy Markdown
Member

@ifireball the behaviour tests were failing because bug was not added, this makes that deterministic, is this a good approach? Or do we want to check how many times the LLM gets that right (making PR tests flaky)?

@rh-hemartin rh-hemartin self-assigned this Jul 10, 2026
@rh-hemartin rh-hemartin mentioned this pull request Jul 10, 2026
Merged
2 tasks
@rh-hemartin

rh-hemartin commented Jul 10, 2026

Copy link
Copy Markdown
Member

Merging it, we can revert back if this goes against the intent of the functional tests.

@rh-hemartin
rh-hemartin added this pull request to the merge queue Jul 10, 2026
Merged via the queue into main with commit e187a9d Jul 10, 2026
11 checks passed
@rh-hemartin
rh-hemartin deleted the agent/95-bug-label-post-triage branch July 10, 2026 14:59
@fullsend-ai-retro

fullsend-ai-retro Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 3:01 PM UTC · Completed 3:13 PM UTC
Commit: 9ee7398 · View workflow run →

This was referenced Jul 10, 2026
Closed
Open
@fullsend-ai-retro

fullsend-ai-retro Bot commented Jul 10, 2026

Copy link
Copy Markdown

PR #96 fixed a bug where post-triage.sh didn't apply the bug label for bug-category issues. The workflow was efficient: issue filed at 09:55 UTC, triage completed by 09:59, code agent produced a clean single-commit fix by 10:11 (+15/-5 lines, 2 files), human approval at 14:52, merged at 14:59. The code agent followed AGENTS.md principles well (surgical changes, simplicity first). Two systemic issues emerged: (1) the review agent was never dispatched because bot accounts fail authorization checks and the ready-for-review label application failed — this is already tracked upstream in fullsend-ai/fullsend#3996 and #3998; (2) contradictory status comments appeared on the originating issue, showing both 'Terminated' and 'Success'. Additionally, the fix reveals that the documentation category has the same deterministic label gap that bug had before this PR.

Proposals filed

@fullsend-ai-retro fullsend-ai-retro Bot mentioned this pull request Jul 10, 2026
Open
@fullsend-ai-coder fullsend-ai-coder Bot mentioned this pull request Jul 10, 2026
Merged
4 tasks
This was referenced Jul 13, 2026
Closed
Open
@fullsend-ai-coder fullsend-ai-coder Bot mentioned this pull request Jul 13, 2026
Merged
4 tasks
ifireball pushed a commit to ifireball/agents that referenced this pull request Jul 13, 2026
@fullsend-ai-coder
fix(fullsend-ai#103): apply documentation label deterministically in …
accdd7c 
…post-triage

Split the documentation case out of the combined documentation|performance
branch in the sufficient action handler so that documentation-category
issues receive the documentation label, mirroring the bug label fix
from PR fullsend-ai#96. Add documentation to CONTROL_LABELS to prevent the agent
from manipulating it via label_actions.

Test: add sufficient-documentation-gets-documentation-label test case
and include documentation in the mock label list.

Closes fullsend-ai#103
ifireball pushed a commit to ifireball/agents that referenced this pull request Jul 13, 2026
@fullsend-ai-coder
docs(fullsend-ai#128): update control labels table and example to lis…
421d852 
…t all 9 labels

Add missing rows for feature, question, bug, and documentation to
the control labels table in docs/triage.md. Update the ready-to-code
row to note that bug and documentation categories also receive their
eponymous labels automatically. Update the example issue-labels skill
snippet to list all 9 control labels instead of 5.

The CONTROL_LABELS array in scripts/post-triage.sh has 9 entries but
the docs only listed 5. PRs fullsend-ai#96 and fullsend-ai#109 added bug and documentation
to the array without updating the docs.

Closes fullsend-ai#128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ralphbean ralphbean ralphbean approved these changes
@ifireball ifireball Awaiting requested review from ifireball

Assignees

@rh-hemartin rh-hemartin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

post-triage.sh does not apply bug label for bug-category issues

2 participants

@rh-hemartin @ralphbean