Repository navigation
refactor(group,dedup): reduce duplication and remove dead code - #153
Conversation
…rics and remove dead parameter - Replace local TagFamilySizeMetric struct in group.rs with FamilySizeMetrics from fgumi-metrics crate (dedup.rs already used this) - Add FamilySizeMetrics::from_size_counts() to centralize histogram computation that was duplicated in both group.rs and dedup.rs - Add PartialEq derive to FamilySizeMetrics for test assertions - Remove dead _assign_tag_bytes parameter from assign_umi_groups_for_indices_impl and its callers (tags are set during serialization, not assignment) - Remove unused serde import from group.rs
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
+ Coverage 83.61% 83.62% +0.01%
==========================================
Files 126 126
Lines 51510 51475 -35
==========================================
- Hits 43069 43048 -21
+ Misses 8441 8427 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
TagFamilySizeMetricstruct in group.rs withFamilySizeMetricsfrom fgumi-metrics (dedup.rs already used this)FamilySizeMetrics::from_size_counts()to centralize the histogram computation that was duplicated verbatim in both group.rs and dedup.rs_assign_tag_bytesparameter that was threaded through 3 functions but never used (tags are set during serialization)serdeimportTest plan
cargo ci-test)cargo ci-fmt)cargo ci-lint)FamilySizeMetrics::from_size_counts()(normal + empty cases)