Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release notes #2778

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Update release notes #2778

merged 1 commit into from
Jul 11, 2024

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Jun 4, 2024

refs #2738 (comment)

This is just grabbing a couple of notable changes, and I'm not sure what the next version will be, so maybe it's a placeholder than a complete change

@Numpsy
Copy link
Contributor Author

Numpsy commented Jun 4, 2024

Also, the macOS CI builds might fail unless we do #2773 or update the .NET SDK or something like that

@voronoipotato
Copy link
Contributor

Looks great! Thanks @Numpsy !! 🎉🎉🎉

@xperiandri
Copy link
Collaborator

Does anyone know how to fix the build?

@Numpsy
Copy link
Contributor Author

Numpsy commented Jun 5, 2024

Does anyone know how to fix the build?

If the issue is dotnet/runtime#64103 then it looks like either change the macOS runner from macOS-latest to macOS(12/13) (e.g. #2773) or update the .NET SDK used in the build to 6.0.300 or newer.

@smoothdeveloper
Copy link
Contributor

@xperiandri I noticed in #2768 (which also updates release notes) that you rebased / repushed commits I did in that branch, I think it is better to just append commits and let the branch author do rebase in case it is needed, there is also concern it can mess the contribution history in github (which is nice for people that begin contribution).

#2768 should be merged and released, IMO, it is not because macOS CI fails in that particular branch, that it is related to it, most FAKE users can't leverage terminal logger goodness until it ships.

@xperiandri
Copy link
Collaborator

@smoothdeveloper let's fix the build in a separate PR and rebase this one on top. Anyway, if a build does not happen I will not be able to release anything. A release also requires building 🙂

@smoothdeveloper
Copy link
Contributor

@xperiandri mmh, I didn't see there are artifacts for each platform.

I'm not aware of the reason for it, as I assumed there are no non-CLI binaries shipped for fake but I'm probably overlooking something.

@voronoipotato
Copy link
Contributor

@xperiandri how do we update .net core to 6.0.5 for that the macOS-latest target so we can keep moving?

@xperiandri
Copy link
Collaborator

Submit another PR with a fix

@Numpsy
Copy link
Contributor Author

Numpsy commented Jun 16, 2024

@xperiandri how do we update .net core to 6.0.5 for that the macOS-latest target so we can keep moving?

I tried doing it in #2780 and got a different error :-(

@Numpsy
Copy link
Contributor Author

Numpsy commented Jun 16, 2024

Grasping at straws a bit here, but - #2781.
(Unclear if there is actually a real FAKE issue here on ARM cpu macs that might effect end users as well)

@voronoipotato
Copy link
Contributor

@Numpsy maybe we should reach out to people in the slack and discord and see if anyone has an arm macbook that they can help test this with. I have an arm surface pro x, but I doubt that will be helpful.

@Numpsy
Copy link
Contributor Author

Numpsy commented Jun 27, 2024

At this point, I think it might be nice to just try to get the build pipeline running successfully on the Intel Mac runners, and have 'fix ARM problems' as a seperate work item once there's a more stable base

@voronoipotato
Copy link
Contributor

that seems good, I hear the rosetta x86 emulation is very good anyway, it feels like a "nice to have".

@Numpsy
Copy link
Contributor Author

Numpsy commented Jul 11, 2024

Hurrah, build succeeded

@xperiandri xperiandri merged commit d8f9961 into fsprojects:master Jul 11, 2024
3 checks passed
@Numpsy Numpsy deleted the bump_rn branch July 11, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants