Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for /tl:[auto|on|off] msbuild flag #2768

Merged

Conversation

smoothdeveloper
Copy link
Contributor

Description

see --tl:[auto|on|off] on dotnet build documentation: https://learn.microsoft.com/en-gb/dotnet/core/tools/dotnet-build

Since this only works with dotnet sdk >= 8, the default case (specifying Auto) will not emit the tag.

TODO

Feel free to open the PR and ask for help

  • New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in help/markdown)

  • unit or integration test exists (or short reasoning why it doesn't make sense)

    Note: Consider using the CreateProcess API which can be tested more easily, see https://github.com/fsharp/FAKE/pull/2131/files#diff-4fb4a77e110fbbe8210205dfe022389b for an example (the changes in the DotNet.Testing.NUnit module)

  • boy scout rule: "leave the code behind in a better state than you found it" (fix warnings, obsolete members or code-style in the places you worked in)

  • (if new module) the module has been linked from the "side navigation" menu, edit docs/data.json.

  • (if new module) the module is in the correct namespace.

  • (if new module) the module is added to Fake.sln (dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj)

  • Fake API guideline is honored

@smoothdeveloper
Copy link
Contributor Author

tried it (specificying TerminalLogger = On) in the build.fsx in this repository and it seems to work:

image

src/app/Fake.DotNet.MSBuild/MSBuild.fs Outdated Show resolved Hide resolved
src/app/Fake.DotNet.MSBuild/MSBuild.fs Outdated Show resolved Hide resolved
@smoothdeveloper
Copy link
Contributor Author

image

now with <para/> tags.

@xperiandri
Copy link
Collaborator

Do you have any ideas why build fails?

@smoothdeveloper
Copy link
Contributor Author

@xperiandri no, I see the same on another run on master branch: https://github.com/fsprojects/FAKE/actions/runs/7174371576/job/19535683031

We should investigate but I doubt it is related to this change.

@xperiandri
Copy link
Collaborator

xperiandri commented Dec 20, 2023

Probably something bad with an agent. Maybe update the version of image

@xperiandri
Copy link
Collaborator

Could you rebase onto the latest master?

@smoothdeveloper
Copy link
Contributor Author

@xperiandri not sure what is blocking in CI, seems an upload is timing out.

@xperiandri
Copy link
Collaborator

xperiandri commented Jul 14, 2024

@xperiandri
Copy link
Collaborator

@Thorium @Numpsy what do you think about release notes?

@Thorium
Copy link
Member

Thorium commented Jul 15, 2024

Seems, good to me: a small addition, and there is no new dependencies or anything added. And release notes are there already updated in this PR.

@Numpsy
Copy link
Contributor

Numpsy commented Jul 15, 2024

Is there any manually managed documentation for features like this, or is it just generated out of the XML doc comments?

@xperiandri
Copy link
Collaborator

Conflict appeared

@xperiandri xperiandri merged commit 40b6de5 into fsprojects:master Jul 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants