Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic support for GitHub Actions #2512

Merged
merged 2 commits into from
May 7, 2020
Merged

feat: add basic support for GitHub Actions #2512

merged 2 commits into from
May 7, 2020

Conversation

Bomret
Copy link

@Bomret Bomret commented May 5, 2020

Description

Add basic integration with GitHub Actions.

TODO

Feel free to open the PR and ask for help

  • New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in help/markdown)

  • unit or integration test exists (or short reasoning why it doesn't make sense)

    • just static helpers, no logic

    Note: Consider using the CreateProcess API which can be tested more easily, see https://github.com/fsharp/FAKE/pull/2131/files#diff-4fb4a77e110fbbe8210205dfe022389b for an example (the changes in the DotNet.Testing.NUnit module)

  • boy scout rule: "leave the code behind in a better state than you found it" (fix warnings, obsolete members or code-style in the places you worked in)

  • (if new module) the module has been linked from the "Modules" menu, edit help/templates/template.cshtml, linking to the API-reference is fine.

  • (if new module) the module is in the correct namespace

  • (if new module) the module is added to Fake.sln (dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj)

  • Fake 5 API guideline is honored

@Bomret
Copy link
Author

Bomret commented May 5, 2020

@matthid I created a new PR from a fresh fork of the release/next branch

@matthid
Copy link
Member

matthid commented May 6, 2020

Do we need an 'installer' (see https://fake.build/buildserver.html) and a custom output configuration? For example to support custom tracing or coloring?

Even if the "default" works we should "pin" it in case we decide to change the defaults.

@Bomret
Copy link
Author

Bomret commented May 7, 2020

I haven’t looked much at those features. I just wanted to add basic support, so one can check if the build is happening on GitHub and to access the provided env vars. Are the installer and output colorizing features a must have for basic support or could we iterate on this feature later?

@Bomret
Copy link
Author

Bomret commented May 7, 2020

@matthid I added the installer.

@matthid
Copy link
Member

matthid commented May 7, 2020

Are the installer and output colorizing features a must have for basic support or could we iterate on this feature later?

Yes, we can always iterate but from an API perspective, it makes sense to have those APIs for consistency reasons (even if they do nothing). Thanks a lot!

@matthid matthid merged commit 78eee69 into fsprojects:release/next May 7, 2020
@matthid matthid mentioned this pull request Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants