feat: basic features for GitHub Actions integration #2509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion parameter (default) and the other taking an options record parameter (o suffix)
…elper functions to make creating a SignCertificate easier
…rUrl is now required
I had forgotten to include MS-PL as well.
Forgot to remove a file from the dotnet-fake folder.
Use the correct SPDX license expression.
…they are supposed to contain, nothing more
- using the newest Windows SDK available - working around ProcessUtils.tryFindFile's lack of globbing support
Support running Octo from .net core tool-manifest
The issue referred in the code octokit/octokit.net#963 has since been fixed. The timeout can be set via a method on the client, and per the last comment octokit/octokit.net#963 (comment) this needs to be set on the release upload request as well. If not set, the default per-request timeout of 100 seconds is configured.
General `DotNet.pack` example added
|
Hm, don't know exactly why the buil fails. Seems the appveyor file does not set up the correct dotnet core runtime? |
|
@Bomret Thanks for this, please try to pull the latest release/next changes. This failure was due to the removal of preinstalled dotnet versions on appveyor and is fixed on the latest |
|
oof, I'll do a fresh fork and open a new PR. |
|
Why? Did merging not went through? |
|
I had a very old state of the repo from ~5 years back. The PR suddenly had more than 100 changed files after merging in the latest release/next. Here is the freshly forked one: #2512 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provides basic constructs for GitHub Actions support.
TODO
Feel free to open the PR and ask for help
help/markdown)help/templates/template.cshtml, linking to the API-reference is fine.dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj)