Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI script to latest .NET Core #1973

Merged
merged 2 commits into from
Jun 2, 2018
Merged

Update CI script to latest .NET Core #1973

merged 2 commits into from
Jun 2, 2018

Conversation

teo-tsirpanis
Copy link
Contributor

No description provided.

@matthid
Copy link
Member

matthid commented May 31, 2018

@teo-tsirpanis We have to differentiate between dotnet-fake (https://docs.microsoft.com/en-us/dotnet/core/tools/extensibility#per-project-based-extensibility) and fake-cli (https://docs.microsoft.com/en-us/dotnet/core/tools/global-tools)

  • dotnet-fake which is used by travis (and other CIs) will still work
  • fake-cli will probably no longer work as it was build with 2.1.300-rc and not with the stable release. However we don't use it in any CI yet.

@teo-tsirpanis
Copy link
Contributor Author

teo-tsirpanis commented May 31, 2018 via email

@matthid
Copy link
Member

matthid commented May 31, 2018

#1972 :)

@teo-tsirpanis
Copy link
Contributor Author

I see...

@matthid
Copy link
Member

matthid commented May 31, 2018

We still need this change :)
All I'm saying is that it doesn't reproduce the problem we were talking about in #1864

@matthid matthid reopened this May 31, 2018
@matthid matthid changed the base branch from master to release/rc May 31, 2018 12:22
@matthid
Copy link
Member

matthid commented May 31, 2018

Problem seems that they don't have the version on travis yet

@matthid matthid merged commit 3f7b6a0 into fsprojects:release/rc Jun 2, 2018
@teo-tsirpanis teo-tsirpanis deleted the patch-1 branch January 14, 2019 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants