.Net Core 2.1

[kblohm]

Hi,
as .Net Core 2.1 was just released, i updated FAKE to use the new version.
I split the update in 2 commits:

1. Adds the new version to the DotNet-Module and uses the release version in the build instead of the RC.
2. Replaces netcore2.0 with 2.1. I am not sure if we want to do this already or maybe just do it for tests and not for fake-dotnet. If we do not want to update yet or not update the tools, i can revert/adjust this one.

[matthid]

Yes the only interesting impact is dotnet-fake because it will no longer work when people have 2.0. Everything else probably doesn't matter that much and we can upgrade

[0x53A]

What is the advantage to updating? Breaking 2.0 without any reason seems .... not good?

[kblohm]

Updating dotnet-fake has no real advantage as far as i can tell. I read that you have to rebuild global cli tools when the full version is released, so fake-cli might not work anymore now for some people. Its working for me though, so i am not sure if that is actually the case.

[matthid]

@0x53A Updating everything else besides "dotnet-fake" should be "safe" and gets all the performance and runtime improvements.

[matthid]

Thanks! The only thing is about dotnet-fake but the rest is probably reasonable. We can release and see what happens :)

[matthid]

any idea why every line changed? Line ending changed?

[kblohm]

Auto-Format on save in vscode. Probably uses the 4 spaces from the editorconfig.

[matthid]

Ah I didn't noticed, thanks. Can we change that for project files to two? Or just leave it as is. Now that I understand whats going on :)
But I think two is what the files use when auto generated (for example via dotnet new), correct?

[matthid]

I think we should consider leaving netcoreapp2.0 (or both) here

[kblohm]

I will change that later today when i am at home. Do you want both or just 2,0?

[matthid]

Thanks! I guess leaving 2.0 for now is the better option. We just wait until people start complaining.

[kblohm]

I also added *.fsproj to the editorconfig to fix the indentation issue.
If you want me to squash or something, ping :).

[parthopdas]

@matthid can you please push this out to nuget?

[matthid]

@kblohm Thanks for taking care of this!
@parthopdas Yes sure, once we made sure everything works on staging ;)