Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Candidate 16 #1949

Merged
merged 36 commits into from
May 21, 2018
Merged

Release Candidate 16 #1949

merged 36 commits into from
May 21, 2018

Conversation

matthid
Copy link
Member

@matthid matthid commented May 21, 2018

No description provided.

BlythMeister and others added 29 commits May 14, 2018 12:05
Fix broken link to `Add FAKE Dependencies` section on migration guide
add some logic to write relative instead of absolute paths to cache, …
WIP: Run final targets after user cancels with ctrl+c
@matthid
Copy link
Member Author

matthid commented May 21, 2018

@kblohm You might check now if your workflow with Ctrl+C now works with the version deployed to staging (you can for example use the staging branch I pushed for testing)

@matthid
Copy link
Member Author

matthid commented May 21, 2018

Oh I see the following on staging:

2018-05-21T20:16:59.3753740Z   Script reported an error:
2018-05-21T20:16:59.3813756Z   -> FileNotFoundException: Could not load file or assembly 'System.Reactive.Linq, Version=3.0.3000.0, Culture=neutral, PublicKeyToken=94bc3704cddfc263'. The system cannot find the file specified.
2018-05-21T20:17:00.0654580Z   -> FileNotFoundException: Could not load the specified file.

@matthid
Copy link
Member Author

matthid commented May 21, 2018

@kblohm Seems the reason is that https://www.myget.org/feed/fake-vsts/package/nuget/Fake.Core.Target/5.0.0-rc016.217+vsts.4ee2ee35f3cdbed2fb7be91a616e6184dc616566 doesn't list the new dependency. I thought that would work automatically :/

@matthid
Copy link
Member Author

matthid commented May 21, 2018

Ah wait it is there, no idea what's going on actually

@matthid
Copy link
Member Author

matthid commented May 21, 2018

Nevermind was my fault. Didn't do a proper paket update but manually edited the lockfile (which usually works)

@matthid matthid merged commit 896e227 into master May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants