Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Fake-Cache a bit portable #1924

Closed
matthid opened this issue May 12, 2018 · 8 comments
Closed

Make Fake-Cache a bit portable #1924

matthid opened this issue May 12, 2018 · 8 comments

Comments

@matthid
Copy link
Member

matthid commented May 12, 2018

Description

Currently you cannot move your fake-cache alongside the script without any bad sideeffects.
This issue should be used to investigate where we can automatically invalidate/detect such scenarios and also investigate where we can for example save relative paths to allow copying.

@OlegZee
Copy link

OlegZee commented May 13, 2018

@matthid, is it the same case as if I put the build script to folder:
image

@matthid
Copy link
Member Author

matthid commented May 13, 2018

@OlegZee I guess you mean "Moving" the script to a different folder or moving the project?

@OlegZee
Copy link

OlegZee commented May 14, 2018

@matthid I just moved the script to a samples folder and now I cannot run it without changing current folder.

@matthid
Copy link
Member Author

matthid commented May 14, 2018

Yes we need to allow that. Current workaround is to rm -rf .fake...
Basically I always thought the .fake is not in the working directory but alongside the script (or maybe it is always alongside paket.dependencies, not sure which one is better actually).

@OlegZee
Copy link

OlegZee commented May 14, 2018

Btw, do you know FAKE is also affected by an https://github.com/dotnet/cli/issues/4808? Offtopic here but hardly deserve its own issue.

@matthid
Copy link
Member Author

matthid commented May 14, 2018

Basically yes, however nobody seems to notice because fake is in the root folder and not a lot of stuff is living there I guess. Or people use chocolatey ;)

@matthid
Copy link
Member Author

matthid commented May 21, 2018

I think this is solved by storing relative paths (relative to the script) into the fake cache in addition to detecting the nuget-packages directory. This should cover most cases besides the one you posted @OlegZee . To handle that scenario I think it makes the most sense to detect that error and hint the user into deleting the .fake directory.

@matthid
Copy link
Member Author

matthid commented May 21, 2018

or save the .fake directory always alongside the script path (not the working directory)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants