Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn old NpmHelper into a Fake 5 module #1822

Merged
merged 3 commits into from
Mar 18, 2018

Conversation

severisv
Copy link
Contributor

@severisv
Copy link
Contributor Author

I'm a little confused by this (from https://fake.build/contributing.html):

In order, to have a more consistent API we propose to always use camelCase naming for functions

So I implemented the API in camelCase, but looking at the rest of the Fake API, PascalCase seems to be what's used.

@matthid
Copy link
Member

matthid commented Mar 16, 2018

In order, to have a more consistent API we propose to always use camelCase naming for functions

Yes we have to decide for something. However it is quite difficult for some reasons:

  • .NET APIs have PascalCase consistently, and we don't duplicate all of them (but we integrate into them, for example File and Directory module)
  • F# APIs (FSharp.Core) have camelCase

We decided for the latter but are not 100% consistent for various reasons (for example history ones). Please feel free to send PRs to fix them.

Btw your PR looks very good, thanks!

@matthid matthid changed the base branch from master to beta_025 March 18, 2018 13:02
@matthid matthid merged commit b7d8a1f into fsprojects:beta_025 Mar 18, 2018
@matthid
Copy link
Member

matthid commented Mar 18, 2018

Thanks a lot for taking care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants