Change how npm.cmd is located in NpmHelper #1629
Conversation
I've noticed that Yarn adds `nodejs\bin` to the path variable, which would return in the old method used to find npm.cmd, but not actually contain the npm.cmd file. I also removed the fallback to the npm.js package, as it is silly to assume where the package directory is. If people are using that package they should overwrite the NpmFilePath variable.
|
Maybe I should have pointed this against the |
|
|
|
Sorry for the late response. Ideally this PR would include the migration of the NPMModule to a FAKE 5 module (see https://github.com/fsharp/FAKE/blob/master/help/markdown/contributing.md):
There is also a guide how to do it (https://github.com/fsharp/FAKE/blob/master/help/markdown/contributing.md#porting-a-module-to-fake-5). Do you think you can tackle that? This will ensure this module will still be available on the .netcore (future) version of FAKE. The code itself makes sense, the package is hopelessly outdated anyway. Question is: Should there be a way for users to provide a fallback/the path to the executable? |
matthid
added
the
waiting for author
They can already do that using the
I'll look into it |
matthid
added
Fake 5 module required
help wanted
and removed
waiting for author
|
Solved by #1822 |
I've noticed that Yarn adds
nodejs\binto the path variable, which in the old code could return a folder that did not contain the npm.cmd file. I fixed this and also removed the fallback to the npm.js package, as it is silly to assume where the package directory is. If people are using that package they should overwrite the NpmFilePath variable.