fix: add slot_number support to t8n and testing_buildBlockV1#1
Open
qu0b wants to merge 3 commits intofselmo:feat/update-t8n-for-amsterdamfrom
Open
Conversation
Three fixes for Amsterdam/EIP-7843 compatibility: 1. t8n: output currentSlotNumber in execution result - Add SlotNumber field to ExecutionResult - Default to block number for Amsterdam when not provided in env - Output in JSON result so EELS fill framework can include it in fixtures 2. t8n: update gen_execresult.go marshaling for SlotNumber 3. testing_buildBlockV1: pass slotNumber through to block builder - api_testing.go: Extract SlotNumber from PayloadAttributes - payload_building.go: Forward slotNum in BuildTestingPayload's generateParams Without fix MariusVanDerWijden#3, testing_buildBlockV1 fails with "no slot number set post-amsterdam" on any Amsterdam-active chain. Without fixes #1-2, EELS-generated Amsterdam fixtures lack slotNumber in block payloads, causing geth to reject them with "nil slotnumber post-amsterdam". Tested: 44/44 BAL scenario benchmarks pass in benchmarkoor with geth across all 3 BAL execution modes (full, sequential, nobatchio). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…umber-and-testing-buildblock
fselmo
force-pushed
the
feat/update-t8n-for-amsterdam
branch
from
baa5fe4 to
b2f71f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three fixes for Amsterdam/EIP-7843 compatibility needed to run BAL benchmarks via benchmarkoor.
1. t8n: output
currentSlotNumberin execution resultThe EELS fill framework reads the t8n output JSON to construct fixture headers. Without
currentSlotNumberin the output, Amsterdam fixtures lackslotNumberin block payloads, and geth rejects them with"nil slotnumber post-amsterdam".SlotNumberfield toExecutionResultstructslotNumber = blockNumberfor Amsterdam blocks when not provided in envcurrentSlotNumberin the JSON result2.
testing_buildBlockV1: passslotNumberthrough to block builderThe
BuildBlockV1RPC handler doesn't forwardPayloadAttributes.SlotNumbertoBuildPayloadArgs.SlotNum, soBuildTestingPayloadcreatesgenerateParamswithoutslotNum. This causes"no slot number set post-amsterdam"on any Amsterdam-active chain.Files:
eth/catalyst/api_testing.go— ExtractSlotNumberfrom payload attributesminer/payload_building.go— AddslotNum: args.SlotNumtogenerateParamsinBuildTestingPayload3. Updated
gen_execresult.gomarshalingAdded
SlotNumberto both marshal and unmarshal structs in the gencodec-generated file.Testing
With these fixes + corresponding EELS changes (jochem-brouwer/execution-specs#3):
testing_buildBlockV1works on frozen snapshots for stateful benchmark payload generationRelated
🤖 Generated with Claude Code