Abi tests#3
Closed
MariusVanDerWijden wants to merge 15 commits into
Closed
Conversation
Due to refactors to the code, we do not need the arguments.LengthNonIndexed function anymore. You can still get the length by calling len(arguments.NonIndexed())
MariusVanDerWijden
pushed a commit
that referenced
this pull request
Oct 5, 2020
core/types: use stacktrie for derivesha trie: add stacktrie file trie: fix linter core/types: use stacktrie for derivesha rebased: adapt stacktrie to the newer version of DeriveSha Co-authored-by: Martin Holst Swende <martin@swende.se> More linter fixes review feedback: no key offset for nodes converted to hashes trie: use EncodeRLP for full nodes core/types: insert txs in order in derivesha trie: tests for derivesha with stacktrie trie: make stacktrie use pooled hashers trie: make stacktrie reuse tmp slice space trie: minor polishes on stacktrie trie/stacktrie: less rlp dancing core/types: explain the contorsions in DeriveSha ci: fix goimport errors trie: clear mem on subtrie hashing squashme: linter fix stracktrie: use pooling, less allocs (#3) trie: in-place hex prefix, reduce allocs and add rawNode.EncodeRLP Reintroduce the `[]node` method, add the missing `EncodeRLP` implementation for `rawNode` and calculate the hex prefix in place. Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Martin Holst Swende <martin@swende.se>
MariusVanDerWijden
pushed a commit
that referenced
this pull request
Jan 23, 2023
Prune gokzg from crypto/kzg
MariusVanDerWijden
pushed a commit
that referenced
this pull request
Jan 23, 2023
ethapi: Fix gas esitmation for blob txs
MariusVanDerWijden
pushed a commit
that referenced
this pull request
Mar 31, 2025
…m#31081) This PR is #3 of a 3-part series that implements the new log index intended to replace core/bloombits. Based on ethereum#31079 and ethereum#31080 Replaces ethereum#30370 This part removes the old bloombits package and the chain indexer that was only used by bloombits. Deletes the old bloombits database. FilterMaps data structure explanation: https://gist.github.com/zsfelfoldi/a60795f9da7ae6422f28c7a34e02a07e Log index generator code overview: https://gist.github.com/zsfelfoldi/97105dff0b1a4f5ed557924a24b9b9e7 Search pattern matcher code overview: https://gist.github.com/zsfelfoldi/5981735641c956afb18065e84f8aff34 Note that the possibility of a tree hashing scheme and remote proof protocol are mentioned in the documents above but they are not exactly specified yet. These specs are WIP and will be finalized after the local log indexer/filter code is finalized and merged. --------- Co-authored-by: Felix Lange <fjl@twurst.com>
qu0b
added a commit
to qu0b/go-ethereum
that referenced
this pull request
Mar 17, 2026
Three fixes for Amsterdam/EIP-7843 compatibility: 1. t8n: output currentSlotNumber in execution result - Add SlotNumber field to ExecutionResult - Default to block number for Amsterdam when not provided in env - Output in JSON result so EELS fill framework can include it in fixtures 2. t8n: update gen_execresult.go marshaling for SlotNumber 3. testing_buildBlockV1: pass slotNumber through to block builder - api_testing.go: Extract SlotNumber from PayloadAttributes - payload_building.go: Forward slotNum in BuildTestingPayload's generateParams Without fix MariusVanDerWijden#3, testing_buildBlockV1 fails with "no slot number set post-amsterdam" on any Amsterdam-active chain. Without fixes #1-2, EELS-generated Amsterdam fixtures lack slotNumber in block payloads, causing geth to reject them with "nil slotnumber post-amsterdam". Tested: 44/44 BAL scenario benchmarks pass in benchmarkoor with geth across all 3 BAL execution modes (full, sequential, nobatchio). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.