Stage users

[mreynolds389]

There are 2 commits breaking up this work. Next, Preserved Users will be added (that PR will be much smaller)

[carma12]

Some changes were requested. Also, some things that I noticed through the UI (not mentioned in the inline comments):

• The status column is not needed in the 'Stage users' main table.
• Under 'Stage users' > 'Add user':
  • The question mark icon in the Class field is not needed in this form.
  • The No private group checkbox field is not needed in this form.
  • The GID field is not needed in this form.

[carma12]

Apparently, this field should be only available for 'Active' users, not 'Staged' ones. So this should be adapted to be here only if the from prop is "stage-users".

[mreynolds389]

Apparently, this field should be only available for 'Active' users, not 'Staged' ones. So this should be adapted to be here only if the from prop is "stage-users".

It is required for stage users

[mreynolds389]

@carma12 all changes made (I had to keep some changes for the modal field validation to work correctly). Please review...

[carma12]

I added more comments requesting some tiny bits in the code (mostly naming and some Qs).

Apart from that, it seems that some changes in the AddUser component have been pushed in both commits (it was hard for me to find the recently requested changes). No need to correct that.

[carma12]

What is the purpose of this checkbox? This is not in the current WebUI either.

[mreynolds389]

Oh yeah, this is an option you can use with the CLI when activating users. Figured if the CLI can do it, then so should the UI.

[vagrant@server ~]$ ipa stageuser-activate --help
Usage: ipa [global-options] stageuser-activate LOGIN [options]

Activate a stage user.
Options:
  -h, --help    show this help message and exit
  --all         Retrieve and print all attributes from the server. Affects
                command output.
  --raw         Print entries as stored on the server. Only affects output
                format.
  --no-members  Suppress processing of membership attributes.

[carma12]

Oh, didn't know about this. I think it is a nice feature to keep then :)

[mreynolds389]

I added more comments requesting some tiny bits in the code (mostly naming and some Qs).

Apart from that, it seems that some changes in the AddUser component have been pushed in both commits (it was hard for me to find the recently requested changes). No need to correct that.

Ok I'm not sure how that happened :-( This should be a single commit (not 2). Hmm I might have to recreate this PR from scratch...

[mreynolds389]

I added more comments requesting some tiny bits in the code (mostly naming and some Qs).
Apart from that, it seems that some changes in the AddUser component have been pushed in both commits (it was hard for me to find the recently requested changes). No need to correct that.

Ok I'm not sure how that happened :-( This should be a single commit (not 2). Hmm I might have to recreate this PR from scratch...

Ok, its all fixed now

[carma12]

LGTM!

As we are still waiting for a fix for the gating integration tests problem, the merge of this PR will wait until the fix is released.

Context/TL;DR: The image runners that we are using for the CI are experiencing some errors that will be solved in the next release of macos-12 next week. Link1. Link2.)

[carma12]

Oh, didn't know about this. I think it is a nice feature to keep then :)

[miskopo]

Since the integration tests are non-functional as of now due to the changes to IP address' ranges assigned to the runners, I recommend we treat them as non-blocking.
I have carefully reviewed your changes and they seem to be working as intended. Furthermore, current set of integration tests do not cover operations with Staged users.
The effort to fix the CI is tracked in #622.

Given these circumstances, I approve of merging despite integration tests are being skipped.