docs: separate contributor toolchain pin from consumer MSRV - #14
Draft
freefcw wants to merge 1 commit into
Draft
Conversation
The README implied consumers needed the pinned 1.97.1 toolchain. Verified on Linux that the published crates check cleanly from 1.90.0 upward, so state the consumer floor and where it comes from. Co-authored-by: freefcw <freefcw@gmail.com>
审查者指南(小型 PR 中折叠显示)审查者指南更新 README,将 Rust 1.97.1 贡献者工具链与已验证的 Rust 1.90.0 使用者最低版本区分开来,并解释依赖约束以及未声明包级 rust-version 的原因。 文件级变更
提示和命令与 Sourcery 互动
自定义你的使用体验访问你的控制面板以:
获取帮助Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the README to separate the Rust 1.97.1 contributor toolchain from the verified Rust 1.90.0 consumer floor, explaining the dependency constraints and the absence of a package-level rust-version declaration. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The README said "Building requires the toolchain pinned in
rust-toolchain.toml: Rust1.97.1", which reads as a requirement for anyone depending on the crates. It is only the contributor pin (inherited from upstream Zed). The publishedfc-gpui*crates declare norust-version, so the real consumer floor is set by the dependency tree, and it is considerably lower than 1.97.1.What changed
Docs only — no manifest, feature, or code changes. The paragraph now distinguishes the contributor pin from the verified consumer floor and names the two dependencies that set it.
How the floor was verified
On a Linux x86_64 VM,
cargo checkagainst crates.iofc-gpui = "0.9.0"(default features and--no-default-featuresplusfont-kit,wayland,x11) across stable toolchains:rustc 1.85.0 is not supported by the following packages:(24 deps); forced with a 1.85-compatible lock:error[E0658]: let expressions in this position are unstableinar_archive_writer 0.5.1ar_archive_writerE0658cosmic-text@0.19.0 requires rustc 1.89(no semver-compatible downgrade exists)ordered-float@5.5.0 requires rustc 1.90under resolver v2; passes under resolver v3, which selectsordered-float 5.4.0ordered-float 5.5.0is the only thing standing between 1.89 and 1.90, and1.90holds regardless of the consumer's resolver version, so it is the honest number to publish.Upstream Zed pins
rust-toolchain.tomlto the same1.97.1and likewise declares norust-versiononcrates/gpui(published asgpui 0.2.2); this change keeps the fork aligned with that convention while telling consumers the truth.Sourcery 总结
明确贡献者和使用者所需的不同 Rust 工具链版本。
增强功能:
文档:
Original summary in English
Summary by Sourcery
Clarify the separate Rust toolchain requirements for contributors and consumers.
Enhancements:
Documentation: