Use the collection slug field name #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cédric Boirard <[email protected]>
3 tasks
tom-james-watson
approved these changes
Mar 17, 2025
alecmev
reviewed
Mar 17, 2025
|
|
||
| for (const field of supportedFields) { | ||
| const value = item.fieldData[field.id] | ||
| const fieldData = item.fieldData[field.id] |
Contributor
There was a problem hiding this comment.
Nit: fieldDataEntry 😛 (for some follow-up PR, if any)
alecmev
reviewed
Mar 17, 2025
| const fieldData = item.fieldData[field.id] | ||
|
|
||
| switch (field.type) { | ||
| switch (fieldData.type) { |
Contributor
There was a problem hiding this comment.
Is this safe? May it not be undefined?
Member
Author
There was a problem hiding this comment.
Before it could have been but since 3.0 with strictly typed FieldData, it should never happen
Member
Author
There was a problem hiding this comment.
fieldData.value may be undefined though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/framer/company/issues/32023
Description
This pull request ensure we export the collection slug field name (when available) instead of
Slug.Testing