Skip to content

Conversation

@NiklasPor
Copy link
Contributor

Description

Notion supports blockquotes and Framer is supporting blockquotes. We were missing the blockquotes from notion so I added them.

Testing

  • Add a blockquote in a notion doc
    • Sync the notion doc to your database
    • Check if it appears correctly

image

@NiklasPor NiklasPor changed the title Add block quote support Notion Plugin: Add block quote support Feb 25, 2025
@mintplo
Copy link

mintplo commented Mar 17, 2025

I appreciate your efforts, and I also needed this feature.

Based on this PR, I think it would be best to assign code reviewers so that they can review your code.

CleanShot 2025-03-17 at 21 46 23

Also, your other PR need assign reviewers too.

@hacksman
Copy link

hacksman commented May 9, 2025

Add pls 🙌

@NiklasPor
Copy link
Contributor Author

@mintplo I don't have the permissions to assign reviewers. @triozer / @tom-james-watson can you assign someone?

@triozer triozer self-assigned this Jun 10, 2025
Copy link
Member

@triozer triozer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @NiklasPor!

@triozer triozer merged commit 8e9bee5 into framer:main Jun 10, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants