Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise minimum Python version to 3.9, start testing 3.13 #260

Merged
merged 2 commits into from
Apr 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/test-gnofract4d.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ jobs:
strategy:
matrix:
os: [ubuntu-22.04]
python: ["3.8", "3.9", "3.10", "3.11"]
python: ["3.9", "3.10", "3.11", "3.12", "3.13-dev"]
toxenv: [py]
# Ensure ../codecov.yml uploads after all py jobs
include:
- os: macos-12
python: "3.7"
python: "3.9"
toxenv: py

env:
Expand Down Expand Up @@ -57,6 +57,7 @@ jobs:
- name: Run Tox (MacOS)
if: ${{ runner.os == 'macOS' }}
run: tox -e ${{ matrix.toxenv }}
continue-on-error: true # Gio introspection is broken: https://gitlab.gnome.org/GNOME/glib/-/issues/3322
- name: Run Tox (Linux)
if: ${{ runner.os == 'Linux' }}
run: xvfb-run --auto-servernum tox -e ${{ matrix.toxenv }}
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Requirements

Gnofract 4D requires these packages to run:

- Python version 3.6 or higher
- Python version 3.9 or higher
- GTK version 4.6 or higher
- PyGObject version 3.29.2 or higher to access GTK from Python
- A C compiler (used at runtime to compile your fractal formulas)
Expand Down
3 changes: 0 additions & 3 deletions fract4d/c/fract4dmodule.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -651,9 +651,6 @@ PyInit_fract4dc(void)
return NULL;
}

// todo: check this https://docs.python.org/3/c-api/init.html#c.PyEval_InitThreads
PyEval_InitThreads();

/* expose some constants */
PyModule_AddIntConstant(pymod, "CALC_DONE", GF4D_FRACTAL_DONE);
PyModule_AddIntConstant(pymod, "CALC_CALCULATING", GF4D_FRACTAL_CALCULATING);
Expand Down
4 changes: 2 additions & 2 deletions meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ pymod = import('python')
py = pymod.find_installation()

py_version = py.language_version()
if py_version.version_compare('< 3.6')
error('Sorry, you need Python 3.6 or higher to run Gnofract 4D.'
if py_version.version_compare('< 3.9')
error('Sorry, you need Python 3.9 or higher to run Gnofract 4D.'
+ ' You have version ' + py_version + '. Please upgrade.')
endif

Expand Down
Loading