Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise minimum Python version to 3.9, start testing 3.13 #260

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

cjmayo
Copy link
Collaborator

@cjmayo cjmayo commented Mar 25, 2024

PyEval_InitThreads() does nothing in Python 3.9-12 and is dropped in 3.13.


Python 3.8 does have a few months left but with the change to GTK 4 we dropped compatibility with Ubuntu 20.04 anyway.

PyEval_InitThreads() does nothing in Python 3.9-12 and is
dropped in 3.13.
@cjmayo
Copy link
Collaborator Author

cjmayo commented Mar 25, 2024

Looks like Meson 1.4.0 isn't compatible with Python 3.13 yet. Will investigate.

@cjmayo
Copy link
Collaborator Author

cjmayo commented Mar 26, 2024

A feature that Meson relies on has been removed. It wasn't listed for removal in 3.13 in the original Python 3.12 documentation, and looks like it is now coming back. Could be fixed in a couple of weeks time with the next Python 3.13 alpha. This was one that needed to sit for a bit anyway.

Perhaps it is a bit early to start testing with Python 3.13, but as the purpose was to be compatible with it...

No rush.

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.71%. Comparing base (06e34bb) to head (90f2b63).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #260   +/-   ##
=======================================
  Coverage   85.70%   85.71%           
=======================================
  Files          55       55           
  Lines       10424    10431    +7     
=======================================
+ Hits         8934     8941    +7     
  Misses       1490     1490           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cjmayo
Copy link
Collaborator Author

cjmayo commented Apr 14, 2024

Python 3.13.0a6 is released so Meson is happy.

But, in news elsewhere, Homebrew have updated to packages that do not work on macOS, causing a test failure:

 >       @pytest.mark.skipif(Gio.AppInfo.get_default_for_uri_scheme("http") is None,
                            reason="No web browser found")
E                           AttributeError: type object 'AppInfo' has no attribute 'get_default_for_uri_scheme'

Homebrew/homebrew-core#167524
https://gitlab.gnome.org/GNOME/glib/-/issues/3322

Added a commit here for now to bypass that to see the Linux tests pass. I guess we wait for a new release to fix that, and we have the time.

Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to us - feel free to merge when you're ready to.

@cjmayo
Copy link
Collaborator Author

cjmayo commented Apr 29, 2024

Let's get on with it - the macOS job is causing all check runs to fail. Compilation on macOS is being run at least.

@cjmayo cjmayo merged commit 9373037 into fract4d:master Apr 29, 2024
9 checks passed
@cjmayo cjmayo deleted the python39 branch April 29, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants