Skip to content

Enabled setting fan level for AirPurifier 3/3H#1

Merged
foxel merged 1 commit intofoxel:mi_purifier_3from
pkrolkgp:mi_purifier_3
Feb 20, 2020
Merged

Enabled setting fan level for AirPurifier 3/3H#1
foxel merged 1 commit intofoxel:mi_purifier_3from
pkrolkgp:mi_purifier_3

Conversation

@pkrolkgp
Copy link
Copy Markdown

Description:

Added posibility to change 3 fan levels as in MI home app

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@pkrolkgp pkrolkgp requested a review from foxel February 19, 2020 20:04
@foxel foxel merged commit 7d6857e into foxel:mi_purifier_3 Feb 20, 2020
@foxel
Copy link
Copy Markdown
Owner

foxel commented Feb 20, 2020

🔥

@foxel
Copy link
Copy Markdown
Owner

foxel commented Feb 20, 2020

@pkrolkgp since now your commits are in the PR - please see CLA sign request from HomeAssistant: home-assistant#31729 (comment)

@mouth4war
Copy link
Copy Markdown

mouth4war commented Feb 20, 2020

Hi @pkrolkgp Could you also add set_favorite_rpm service to set favorite motor speed?

@pkrolkgp pkrolkgp deleted the mi_purifier_3 branch February 21, 2020 19:07
@pkrolkgp
Copy link
Copy Markdown
Author

Hi @pkrolkgp Could you also add set_favorite_rpm service to set favorite motor speed?

I will try :)

foxel pushed a commit that referenced this pull request Mar 29, 2020
* Significantly reduce code in august integration

* Activity updates can now be processed by py-august
  this allows us to eliminate the activity sync
  code for the door sensors and locks

* Lock and door state can now be consumed from
  the lock detail api which allows us to
  remove the status call apis and reduce
  the number of API calls to august

* Refactor the testing method for locks (part #1)

* Update homeassistant/components/august/binary_sensor.py

Co-Authored-By: Paulus Schoutsen <paulus@home-assistant.io>

* Switch to asynctest instead of unittest for mock.patch

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants