Significantly reduce code in august integration#32030
Merged
balloob merged 3 commits intohome-assistant:devfrom Feb 21, 2020
Merged
Significantly reduce code in august integration#32030balloob merged 3 commits intohome-assistant:devfrom
balloob merged 3 commits intohome-assistant:devfrom
Conversation
* Activity updates can now be processed by py-august this allows us to eliminate the activity sync code for the door sensors and locks * Lock and door state can now be consumed from the lock detail api which allows us to remove the status call apis and reduce the number of API calls to august * Refactor the testing method for locks (part #1)
balloob
reviewed
Feb 20, 2020
balloob
reviewed
Feb 20, 2020
Co-Authored-By: Paulus Schoutsen <paulus@home-assistant.io>
Codecov Report
@@ Coverage Diff @@
## dev #32030 +/- ##
======================================
Coverage ? 94.71%
======================================
Files ? 766
Lines ? 55568
Branches ? 0
======================================
Hits ? 52630
Misses ? 2938
Partials ? 0Continue to review full report at Codecov.
|
balloob
approved these changes
Feb 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Activity updates can now be processed by py-august
this allows us to eliminate the activity sync
code for the door sensors and locks
Lock and door state can now be consumed from
the lock detail api which allows us to
remove the status call apis and reduce
the number of API calls to august
Refactor the testing method for locks (part Unresolved TODO in /homeassistant/components/httpinterface/__init__.py : 575 #1) -- more in the next PRs
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: