Skip to content

[wip] feat: provider alloy migration#7106

Merged
mattsse merged 71 commits intomasterfrom
evalir/cast-provider-mig
Apr 9, 2024
Merged

[wip] feat: provider alloy migration#7106
mattsse merged 71 commits intomasterfrom
evalir/cast-provider-mig

Conversation

@Evalir
Copy link
Member

@Evalir Evalir commented Feb 13, 2024 •
edited by klkvr
Loading

Motivation

This migrates anvil, cast and most of the forge to use alloy providers and primitive types on all methods.

Closes #7486
Closes #7400
Closes #5709
Closes #7089

Solution

@Evalir Evalir mentioned this pull request Feb 14, 2024
Merged
@Evalir
feat(foundry-common): NameOrAddress ENS util (#7122)
3de8241 
* feat(foundry-common): NameOrAddress ENS util

* chore: rename err

* chore: remove from impl for str

* chore: unrelated fix from alloy upgrade

* nit
gakonst
gakonst reviewed Feb 15, 2024
View reviewed changes
@Evalir Evalir mentioned this pull request Feb 15, 2024
Merged
Evalir and others added 8 commits February 16, 2024 12:37
@Evalir @mattsse
feat(cast): Move non tx methods to alloy (#7129)
f9d6c99 
* chore: add alloy contract

* feat(cast): migrate most methods to alloy

* chore: leave todo for converting a tx envelope into an rpc tx

* fix: use proper type for storage

* readd decodetx for now

* chore: extend txbuilder to build an alloy tx request

* feat: migrate most methods bar send/decode raw tx

* fix: include tx data

* simplify txbuilder

* chore: simplify back access_list

* chore: remove unnecesary conversion

* fmt

* doctests

* fmt

* do not use trait

* Update crates/cast/bin/main.rs

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>

* cleanup builder

* clippy

* fix doc comments

---------

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
@Evalir
Merge branch 'master' into evalir/cast-provider-mig
0f98e03
@klkvr
Merge branch 'master' into evalir/cast-provider-mig
c983f50
@klkvr
DocumentMut
e482bee
@klkvr
wip
953f915
@klkvr
wip
435be40
@klkvr
wip: bump alloy
d286ae0
@klkvr
wip
04ca105
@zerosnacks zerosnacks self-assigned this Mar 19, 2024
@klkvr klkvr assigned klkvr and unassigned zerosnacks Mar 19, 2024
@klkvr
Copy link
Member

klkvr commented Mar 21, 2024

Cast now compiles and ethers is almost gone.

We are still using it in 2 places:

  1. crates/cast/bin/cmd/logs.rs - this still uses ethers types to prepare event filters from user-entered event signature and arguments. @DaniPopes does current state of alloy-json-abi and alloy-dyn-abi allow this?

    The flow is basically like this:

    1. Parse signature to extract types
    2. Parse entered values as extracted types (DynSolValue?)
    3. Encode and obtain hashes of indexed fields for filter (not sure if we have that)

  2. crates/cast/bin/cmd/bind.rs - cast bind and forge bind should probably be deprecated?

There are still a lot of errors coming from various places. At the first glance most of them are coming from anvil due to alloy bump and changed transaction types. Will work on that next

cc @mattsse

@klkvr klkvr force-pushed the evalir/cast-provider-mig branch from e9e7e4f to c734de4 Compare April 6, 2024 07:55
@Evalir Evalir requested a review from rkrasiuk as a code owner April 6, 2024 07:55
@klkvr klkvr mentioned this pull request Apr 6, 2024
Merged
3 tasks
@klkvr
Copy link
Member

klkvr commented Apr 7, 2024

blocked by deser issues, should be fixed by alloy-rs/alloy#474

@yash-atreya yash-atreya mentioned this pull request Apr 8, 2024
Merged
3 tasks
@DaniPopes
Copy link
Member

DaniPopes commented Apr 9, 2024

alloy-rs/alloy#474 is merged

mattsse
mattsse approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's send it and do more incremental followups

crates/anvil/core/src/eth/transaction/mod.rs
(Some(1), _, None, None, _, None, None, None) |
(None, _, None, None, Some(_), None, None, None) => {
(Some(1), _, None, None, _, None, None, None, _) |
(None, _, None, None, Some(_), None, None, None, _) => {
Copy link
Member

@mattsse mattsse Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can do this but separately

@klkvr
Copy link
Member

klkvr commented Apr 9, 2024

failing test unrelated I believe

@Evalir
Copy link
Member Author

Evalir commented Apr 9, 2024 •
edited
Loading

#7594 needs to be merged into this before we merge this PR

EDIT: Should be g2g!

@bernard-wagner @Evalir
refactor cast logs to use alloy (#7594)
144dc19 
* refactor cast logs to use alloy

* fmt

* make clippy happy

* cleanup

* doc nits

---------

Co-authored-by: evalir <hi@enriqueortiz.dev>
@mattsse mattsse merged commit f840dbd into master Apr 9, 2024
@mattsse mattsse deleted the evalir/cast-provider-mig branch April 9, 2024 20:52
@Evalir Evalir mentioned this pull request Apr 10, 2024
Closed
2 tasks
This was referenced Apr 26, 2024
Merged
Merged
@klkvr klkvr mentioned this pull request May 20, 2024
Merged
@joroshiba joroshiba mentioned this pull request May 28, 2024
Closed
2 tasks
@klkvr klkvr mentioned this pull request Jun 14, 2024
Closed
2 tasks
@zerosnacks zerosnacks mentioned this pull request Jul 15, 2024
Closed
evadav-663 added a commit to evadav-663/revminc that referenced this pull request Oct 27, 2025
@evadav-663 @mattsse
chore: bump alloy (#78)
8c78737 
Ref foundry-rs/foundry#7106

---------

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
arublee8052-9 added a commit to arublee8052-9/revminc that referenced this pull request Oct 27, 2025
@arublee8052-9 @mattsse
chore: bump alloy (#78)
21bfc29 
Ref foundry-rs/foundry#7106

---------

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gakonst gakonst gakonst left review comments

@DaniPopes DaniPopes DaniPopes left review comments

@mattsse mattsse mattsse approved these changes

@klkvr klkvr Awaiting requested review from klkvr

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

Assignees

@klkvr klkvr

Labels

None yet

Projects

None yet

Milestone

No milestone

9 participants

@Evalir @klkvr @bernard-wagner @DaniPopes @gakonst @mattsse @zerosnacks @grandizzy @kamuik16