chore(deps): bump revm, accomodate new cancun struct changes#5858
Merged
chore(deps): bump revm, accomodate new cancun struct changes#5858
revm, accomodate new cancun struct changes#5858Conversation
DaniPopes
approved these changes
Sep 20, 2023
mattsse
approved these changes
Sep 20, 2023
Member
mattsse
left a comment
There was a problem hiding this comment.
lgtm,
these are all fine since the additional settings are only necessary for eip-4844 transactions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Right now cargo deny, clippy and other ci tests might fail because bluealloy/revm#724 was squashed and rebased against revm's master, which implements 4844, and the sha used doesn't exist anymore.
Solution
revmto use the latest commit on the branch we're usingTxEnv/BlockEnvfields by setting them to default. This should be non-consequential since we're not activating the cancun flag yet.EVMErrors fields by creating the corresponding tx/blockchain errors on anvil/evm. Should be non-consequential since we're not activating cancun yet.Albeit both should be fine for current users, it might be the case that things might be misconfigured if ppl e.g solc team / uniswap team wants to test new opcodes @mattsse — so need to confirm if Defaults are okay (i'm referring to
BlockEnv'sexcess_blob_gas, andTxEnv'smax_fee_per_blob_gasspecifically)