Skip to content

chore(general): replace conversion functions with ToAlloy/ToEthers conv trait#5857

Merged
Evalir merged 4 commits intomasterfrom
evalir/use-conv-traits
Sep 20, 2023
Merged

chore(general): replace conversion functions with ToAlloy/ToEthers conv trait#5857
Evalir merged 4 commits intomasterfrom
evalir/use-conv-traits

Conversation

@Evalir
Copy link
Member

@Evalir Evalir commented Sep 20, 2023

Removes usage of all conversion functions, and uses the ToAlloy and ToEthers trait.

@Evalir Evalir force-pushed the evalir/use-conv-traits branch from 207872f to f8712ed Compare September 20, 2023 01:23
@Evalir Evalir requested a review from mattsse September 20, 2023 01:34
@Evalir
Copy link
Member Author

Evalir commented Sep 20, 2023

CI should be fixed with #5858 and a subsequent rebase

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, needs rebase

@Evalir Evalir merged commit 83b9176 into master Sep 20, 2023
@Evalir Evalir deleted the evalir/use-conv-traits branch September 20, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants