Merged
Conversation
Member
Author
|
cc @DaniPopes @mattsse this should be g2g and should get us back to revm main again. @DaniPopes maybe you can confirm that this does not grind coverage to a halt? i tested locally, but i believe you have a diff OS than me |
mattsse
approved these changes
Aug 23, 2023
2 tasks
mikelodder7
pushed a commit
to LIT-Protocol/foundry
that referenced
this pull request
Sep 12, 2023
* chore: bump revm * chore: fix breaking changes * feat: add coverage test * chore: clippy * chore: switch revm to latest main * Revert "Revert "feat(evm): Use latest revm main commit (foundry-rs#5669)" (foundry-rs#5695)" This reverts commit f8a07c3. * re-add coverage test * fmt * chore: clippy * chore: fix test * chore: fix test * chore: remove unused/unnecessary stuff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #5697. Depends on bluealloy/revm#628
Solution
Coverage was never completing because it was doing extremely slow operations to get the hash every time.
This PR:
revmmain commit.