feat(interpreter): add hash to bytecode#628
Merged
rakita merged 6 commits intobluealloy:mainfrom Aug 23, 2023
Merged
Conversation
This was referenced Aug 22, 2023
rakita
reviewed
Aug 22, 2023
|
|
||
| impl Contract { | ||
| pub fn new(input: Bytes, bytecode: Bytecode, address: B160, caller: B160, value: U256) -> Self { | ||
| let hash = bytecode.hash_slow(); |
Member
There was a problem hiding this comment.
Didnt mean like this. You can pass the hash through the constructor
rakita
reviewed
Aug 22, 2023
rakita
reviewed
Aug 22, 2023
Evalir
force-pushed
the
evalir/add-hash-contract
branch
from
499aef1 to
afb0be9
Compare
Evalir
force-pushed
the
evalir/add-hash-contract
branch
from
afb0be9 to
f895c57
Compare
rakita
reviewed
Aug 23, 2023
rakita
reviewed
Aug 23, 2023
rakita
approved these changes
Aug 23, 2023
mikelodder7
pushed a commit
to LIT-Protocol/revm
that referenced
this pull request
Sep 12, 2023
* feat: add hash to bytecode * chore: introduce args through constructor * chore: lint * chore: do not hash again * chore: load account * chore: use unwrap_or_default and set error
Evalir
added a commit
to Evalir/revm
that referenced
this pull request
Sep 14, 2023
* feat: add hash to bytecode * chore: introduce args through constructor * chore: lint * chore: do not hash again * chore: load account * chore: use unwrap_or_default and set error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caches the bytecode on
Contractto only callhash_slowonce duringContract's creation.Should speed up the coverage interpreter in foundry. cc @rakita