chore: add sourcemaps for JS and minified files #10999 #11012
Conversation
|
Will check tomorrow. |
Poke @DanielRuf 😄 |
gulp/tasks/deploy.js
Outdated
| .pipe(rename({ suffix: '.min' })) | ||
| .pipe(cleancss({ compatibility: 'ie9' })) | ||
| .pipe(sourcemaps.write('.', { | ||
| mapFile: function(path) { return path.replace('.css.map', '.min.css.map'); } |
There was a problem hiding this comment.
This generates .min.min.css.map, should be probably .min.css.map.
There was a problem hiding this comment.
No because Sourcemaps are initialized before the ".min" renaming to be able retrieve original sourcemaps.
So original sourcemaps xxx.css.map are found because source files are still like xxx.css, and this generate xxx.css.map sourcemaps after the minification we rename to xxx.min.css.map.
CSS sources <--[.css.map]-- .css <--[.css.min.map]-- .min.css
There was a problem hiding this comment.
Should be
.pipe(cssFilter)
.pipe(gulp.dest('./dist/css'))
.pipe(sourcemaps.init({ loadMaps: true }))
.pipe(rename({ suffix: '.min' }))
.pipe(cleancss({ compatibility: 'ie9' }))
.pipe(sourcemaps.write('.'))
.pipe(gulp.dest('./dist/css'))
.pipe(cssFilter.restore)
.pipe(jsFilter)
.pipe(gulp.dest('./dist/js'))
.pipe(sourcemaps.init({ loadMaps: true }))
.pipe(rename({ suffix: '.min' }))
.pipe(uglify())
.pipe(sourcemaps.write('.'))
.pipe(gulp.dest('./dist/js'));There was a problem hiding this comment.
Where there are written does only matter, the initialization collects the needed files. ;-)
There was a problem hiding this comment.
hmm... this worked on my side. I'll check that again. Thanks for the review ;)
… task Sourcemaps output names are resolved at writting once source files are already renamed with the `.min` prefix.
|
@DanielRuf Fixed. |
…files-10999 for v6.5.0 3c5507d chore: add JS sourcemaps f1bfe51 chore: add sourcemaps for minified files 6f0a602 style: add some doc for minified source map 9b9ed5f fix: remove useless manual sourcemaps prefixing in gulp "deploy:dist" task Signed-off-by: Nicolas Coden <[email protected]>
Sourcemaps for distribution main files and build JS plugins were added in foundation#11012 but distribution JS plugins were forgotten. This commit change the `deploy:plugins` gulp task to generate and copy sourcemaps for JS plugin alongside their source files. Changes: * Split `deploy:plugins` into `deploy:plugins:sources` and `deploy:plugins:sourcemaps` * Generate sourcemaps for minified plugins in `deploy:plugins:sources` * Copy sourcemaps for plugins to dist folder in `deploy:plugins:sourcemaps`
Changes:
foundation.jsand all plugins)foundation.min.js,foundation-*.min.css)dist:javascriptgulp taskRelated to #10998 (@DanielRuf)
Closes #10999 (@ncoden)