-
Notifications
You must be signed in to change notification settings - Fork 5.5k
fix: copy the sourcemap files #10998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some research and there seems to be no problem with publishing sourcemap to production. So LGTM 👍 .
gulp/tasks/deploy.js
Outdated
@@ -58,6 +59,9 @@ gulp.task('deploy:dist', ['sass:foundation', 'javascript:foundation'], function( | |||
.pipe(rename({ suffix: '.min' })) | |||
.pipe(gulp.dest('./dist/css')) | |||
.pipe(cssFilter.restore) | |||
.pipe(sourcemapFilter) | |||
.pipe(gulp.dest('./dist/css')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing tabulation here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, will change it tomorrow morning if this is ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed.
…iles-10997 for v6.5.0 0ac0fcd fix: copy the sourcemap files (foundation#10998) 4dbf90b add missing indentation Signed-off-by: Nicolas Coden <[email protected]>
This copies the sourcemap files for the unminified development files.
Closes #10997