Skip to content

Conversation

@maze-runnar
Copy link
Contributor

Fixes fossasia/open-event-frontend#7540

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@MeghalBisht
Copy link
Member

@maze-runnar do we need migrations here?

@maze-runnar
Copy link
Contributor Author

@maze-runnar do we need migrations here?

No , as we are allowing none so it is not req.if we move from allow none to req then it will be required

ranjitkshah
ranjitkshah previously approved these changes Jul 17, 2021
@ranjitkshah
Copy link
Member

@maze-runnar tests

@codecov
Copy link

codecov bot commented Jul 17, 2021

Codecov Report

Merging #8102 (86489b7) into development (78e3732) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #8102   +/-   ##
============================================
  Coverage        66.54%   66.54%           
============================================
  Files              302      302           
  Lines            15462    15462           
============================================
  Hits             10289    10289           
  Misses            5173     5173           
Impacted Files Coverage Δ
app/api/event_invoices.py 64.28% <ø> (ø)
app/api/schema/event_invoices.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78e3732...86489b7. Read the comment docs.

@MeghalBisht MeghalBisht merged commit 7589be8 into fossasia:development Jul 20, 2021
@maze-runnar maze-runnar deleted the payment-status branch July 20, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable admin to change event payments to the status "resolved"

3 participants