Skip to content

Conversation

@maze-runnar
Copy link
Contributor

Fixes #7540

required fossasia/open-event-server#8102

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the feature label Jul 15, 2021
@vercel
Copy link

vercel bot commented Jul 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/DwNRbjn5NcT9k9r65Hmo1oRAg8Tf
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-paymen-d8276f-eventyay.vercel.app

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #7561 (74c8dcb) into development (bd52a79) will decrease coverage by 0.02%.
The diff coverage is 9.09%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7561      +/-   ##
===============================================
- Coverage        19.63%   19.60%   -0.03%     
===============================================
  Files              598      598              
  Lines             6871     6881      +10     
  Branches           149      149              
===============================================
  Hits              1349     1349              
- Misses            5495     5505      +10     
  Partials            27       27              
Impacted Files Coverage Δ
app/controllers/admin/sales/invoices.js 0.00% <0.00%> (ø)
app/routes/account/billing/invoices/list.js 80.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd52a79...74c8dcb. Read the comment docs.

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in meeting:

  1. Please add filters to organizer view
  2. Add status info on invoice page. It should not show "Paid" if the user has not paid, e.g. it is possible that the admin of the systems sets a status to resolved for an event that has not paid anything.

@maze-runnar
Copy link
Contributor Author

maze-runnar commented Jul 16, 2021

Screenshot from 2021-07-16 14-25-16
Screenshot from 2021-07-16 14-25-12
Screenshot from 2021-07-16 14-26-58
Screenshot from 2021-07-16 14-26-56

@mariobehling
Copy link
Member

Looks good. Thank you.

@maze-runnar maze-runnar merged commit 4105f88 into fossasia:development Jul 20, 2021
@maze-runnar maze-runnar deleted the payment-status branch July 20, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable admin to change event payments to the status "resolved"

2 participants