Skip to content

fix: User billing details for paying event invoice #6103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2019
Merged

fix: User billing details for paying event invoice #6103

merged 1 commit into from
Jul 2, 2019

Conversation

@mrsaicharan1
Copy link
Member

@mrsaicharan1 mrsaicharan1 commented Jun 24, 2019 •
edited
Loading

Fixes #6039
REQUIRES MERGE OF #6098

Short description of what this resolves:

  • Add model/schema additions for payment details
  • Migration added
  • Followed billing name convention

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@codecov
Copy link

codecov bot commented Jun 24, 2019 •
edited
Loading

Codecov Report

Merging #6103 into development will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6103      +/-   ##
===============================================
+ Coverage         66.5%   66.55%   +0.04%     
===============================================
  Files              286      286              
  Lines            14275    14293      +18     
===============================================
+ Hits              9494     9512      +18     
  Misses            4781     4781
Impacted Files Coverage Δ
app/api/schema/users.py 100% <100%> (ø) ⬆️
app/models/user.py 57.08% <100%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a837b2...0bf414c. Read the comment docs.

@mrsaicharan1 mrsaicharan1 changed the title [WIP]fix: User billing details for paying event invoice fix: User billing details for paying event invoice Jun 25, 2019
@auto-label auto-label bot added the fix label Jun 25, 2019
abhinavk96
abhinavk96 suggested changes Jun 25, 2019
View reviewed changes
abhinavk96
abhinavk96 suggested changes Jun 25, 2019
View reviewed changes
abhinavk96
abhinavk96 suggested changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@abhinavk96 abhinavk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no migration file?

abhinavk96
abhinavk96 suggested changes Jun 25, 2019
View reviewed changes
@mrsaicharan1
Copy link
Member Author

mrsaicharan1 commented Jun 25, 2019 •
edited
Loading

There is no migration file?

Was going to add it once #6098 gets merged. But yeah, can add it now too.

@abhinavk96
Copy link
Contributor

@mrsaicharan1 Yeah wait for it, then you will, either way, have to refactor.

@abhinavk96 abhinavk96 changed the title fix: User billing details for paying event invoice WIP: User billing details for paying event invoice Jun 25, 2019
@auto-label auto-label bot removed the fix label Jun 25, 2019
@abhinavk96 abhinavk96 changed the title WIP: User billing details for paying event invoice wip: User billing details for paying event invoice Jun 25, 2019
@mrsaicharan1 mrsaicharan1 force-pushed the payment-info-f branch 3 times, most recently from f351e9d to 6a0b330 Compare June 28, 2019 04:01
@mrsaicharan1 mrsaicharan1 changed the title wip: User billing details for paying event invoice feat: User billing details for paying event invoice Jun 28, 2019
@auto-label auto-label bot added the feature label Jun 28, 2019
This was referenced Jun 28, 2019
Closed
Merged
@mrsaicharan1 mrsaicharan1 changed the title feat: User billing details for paying event invoice fix: User billing details for paying event invoice Jun 28, 2019
@auto-label auto-label bot removed the feature label Jun 28, 2019
uds5501
uds5501 previously approved these changes Jun 29, 2019
View reviewed changes
Copy link
Contributor

@uds5501 uds5501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

prateekj117
prateekj117 previously approved these changes Jun 29, 2019
View reviewed changes
Copy link
Member

@prateekj117 prateekj117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

iamareebjamal
iamareebjamal previously approved these changes Jun 29, 2019
View reviewed changes
@uds5501 uds5501 mentioned this pull request Jun 30, 2019
Closed
abhinavk96
abhinavk96 previously approved these changes Jul 1, 2019
View reviewed changes
iamareebjamal
iamareebjamal reviewed Jul 1, 2019
View reviewed changes
@mrsaicharan1 mrsaicharan1 force-pushed the payment-info-f branch 2 times, most recently from 9eb6165 to f1d90b9 Compare July 2, 2019 01:39
@mrsaicharan1
User invoice details added
0bf414c 
Changed naming

delete incorrect migration

added migration file

fixed latest migration
@mrsaicharan1
Copy link
Member Author

@iamareebjamal Updated to the latest revision. @shreyanshdwivedi @uds5501

@iamareebjamal iamareebjamal merged commit e3c20af into fossasia:development Jul 2, 2019
iamareebjamal pushed a commit to iamareebjamal/open-event-server that referenced this pull request Aug 2, 2019
@mrsaicharan1 @iamareebjamal
fix: User billing details for paying event invoice (fossasia#6103)
3e76e37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

+4 more reviewers

@abhinavk96 abhinavk96 abhinavk96 left review comments

@uds5501 uds5501 uds5501 left review comments

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi left review comments

@prateekj117 prateekj117 prateekj117 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adding fields for organizer billing info

6 participants

@mrsaicharan1 @abhinavk96 @iamareebjamal @uds5501 @shreyanshdwivedi @prateekj117