- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.9k
 
feat: Model/schema additions for admin billing info #6098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Model/schema additions for admin billing info #6098
Conversation
          Codecov Report
 @@               Coverage Diff               @@
##           development    #6098      +/-   ##
===============================================
+ Coverage        66.16%   66.23%   +0.06%     
===============================================
  Files              285      285              
  Lines            14212    14241      +29     
===============================================
+ Hits              9403     9432      +29     
  Misses            4809     4809
 Continue to review full report at Codecov. 
  | 
    
3146bbb    to
    d7c6b4b      
    Compare
  
    c870caf    to
    9232701      
    Compare
  
    92efd16    to
    8585c53      
    Compare
  
    | 
           @shreyanshdwivedi @uds5501 Please review.  | 
    
4a5c595    to
    b706437      
    Compare
  
    | 
           @shreyanshdwivedi @uds5501 @iamareebjamal Removed the server defaults. Please have a look.  | 
    
418f87e    to
    2f6b3a5      
    Compare
  
    | 
           @iamareebjamal @CosmicCoder96 @uds5501 @shreyanshdwivedi Made the requested changes. Please review.  | 
    
2f6b3a5    to
    85f7fa8      
    Compare
  
    | 
           Okay, might be something on my side. Will check 
…On Wed, 26 Jun 2019 at 9:05 PM, Areeb Jamal ***@***.***> wrote:
 ***@***.**** commented on this pull request.
 ------------------------------
 In app/api/schema/settings.py
 <#6098 (comment)>
 :
 > @@ -196,3 +196,16 @@ class Meta:
      smtp_password = fields.Str(allow_none=True)
      smtp_port = fields.Integer(allow_none=True)
      smtp_encryption = fields.Str(allow_none=True)  # Can be tls, ssl, none
 +
 +    # Admin Invoice Details
 +    admin_billing_contact_name = fields.Str(allow_none=True)
 +    admin_billing_phone = fields.Str(allow_none=True)
 +    admin_billing_email = fields.Email(allow_none=True)
 +    admin_billing_country = fields.Str(allow_none=True)
 +    admin_billing_tax_info = fields.Str(allow_none=True)
 +    admin_company = fields.Str(allow_none=True)
 +    admin_billing_company_address = fields.Str(allow_none=True)
 +    admin_billing_company_city = fields.Str(allow_none=True)
 +    admin_billing_zip = fields.Str(allow_none=True)
 +    admin_billing_additional_info = fields.Str(allow_none=True)
 +    admin_billing_company_comments = fields.Str(allow_none=True)
 @mrsaicharan1 <https://github.com/mrsaicharan1> It'll automatically show
 outdated once you have done the change
 —
 You are receiving this because you were mentioned.
 Reply to this email directly, view it on GitHub
 <#6098?email_source=notifications&email_token=AGAHUWZNKC2MZS3NSLUXCUTP4OED7A5CNFSM4H2X5ZT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4XHAKI#discussion_r297734345>,
 or mute the thread
 <https://github.com/notifications/unsubscribe-auth/AGAHUWYXX2XEQJVLIK5QUD3P4OED7ANCNFSM4H2X5ZTQ>
 .
 
 | 
    
fe47392    to
    9248292      
    Compare
  
    9248292    to
    9ed109f      
    Compare
  
    9ed109f    to
    fe37f5a      
    Compare
  
    | 
           @CosmicCoder96 I've made the changes. Please review.  | 
    
fe37f5a    to
    d4bc75f      
    Compare
  
    Added model fields Added schema fields in Admin API schema Migration file Added server defaults removed server default
d4bc75f    to
    52503fa      
    Compare
  
    change field name
88cf88c    to
    4288001      
    Compare
  
    | 
           @shreyanshdwivedi @uds5501 Please do a peer review.  | 
    
| 
           There's too much repetition. Open an issue to use dataclasses in future:  | 
    
Fixes #6097
Checklist
developmentbranch.Changes proposed in this pull request:
Adds admin invoice details