Skip to content

Conversation

@mrsaicharan1
Copy link
Member

@mrsaicharan1 mrsaicharan1 commented Jun 23, 2019

Fixes #6097

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Changes proposed in this pull request:

Adds admin invoice details

  • schema additions
  • model additions
  • migration file

@codecov
Copy link

codecov bot commented Jun 23, 2019

Codecov Report

Merging #6098 into development will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6098      +/-   ##
===============================================
+ Coverage        66.16%   66.23%   +0.06%     
===============================================
  Files              285      285              
  Lines            14212    14241      +29     
===============================================
+ Hits              9403     9432      +29     
  Misses            4809     4809
Impacted Files Coverage Δ
app/models/setting.py 90.22% <100%> (+1.19%) ⬆️
app/api/schema/settings.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ae00ff...4288001. Read the comment docs.

@mrsaicharan1 mrsaicharan1 changed the title [WIP] fix:Added fields for admin invoice fix:Added fields for admin invoice Jun 24, 2019
@auto-label auto-label bot added the fix label Jun 24, 2019
@mrsaicharan1 mrsaicharan1 changed the title fix:Added fields for admin invoice feat:Added fields for admin invoice Jun 24, 2019
@auto-label auto-label bot added feature and removed fix labels Jun 24, 2019
@mrsaicharan1 mrsaicharan1 changed the title feat:Added fields for admin invoice feat:Model/schema additions for admin billing info Jun 24, 2019
@mrsaicharan1 mrsaicharan1 force-pushed the billing-subtab branch 2 times, most recently from 92efd16 to 8585c53 Compare June 24, 2019 12:40
@mrsaicharan1
Copy link
Member Author

@shreyanshdwivedi @uds5501 Please review.

@mrsaicharan1
Copy link
Member Author

@shreyanshdwivedi @uds5501 @iamareebjamal Removed the server defaults. Please have a look.

@mrsaicharan1 mrsaicharan1 force-pushed the billing-subtab branch 2 times, most recently from 418f87e to 2f6b3a5 Compare June 26, 2019 10:58
@mrsaicharan1
Copy link
Member Author

mrsaicharan1 commented Jun 26, 2019

@iamareebjamal @CosmicCoder96 @uds5501 @shreyanshdwivedi Made the requested changes. Please review.

@mrsaicharan1
Copy link
Member Author

mrsaicharan1 commented Jun 26, 2019 via email

@mrsaicharan1 mrsaicharan1 force-pushed the billing-subtab branch 2 times, most recently from fe47392 to 9248292 Compare June 27, 2019 03:30
@mrsaicharan1
Copy link
Member Author

mrsaicharan1 commented Jun 27, 2019

@CosmicCoder96 I've made the changes. Please review.

Added model fields

Added schema fields in Admin API schema

Migration file

Added server defaults

removed server default
change field name
@mrsaicharan1
Copy link
Member Author

@shreyanshdwivedi @uds5501 Please do a peer review.

@iamareebjamal iamareebjamal changed the title feat:Model/schema additions for admin billing info feat: Model/schema additions for admin billing info Jun 27, 2019
@iamareebjamal
Copy link
Member

There's too much repetition. Open an issue to use dataclasses in future:
https://realpython.com/python-data-classes/

@iamareebjamal iamareebjamal merged commit 6b17f92 into fossasia:development Jun 27, 2019
iamareebjamal pushed a commit to iamareebjamal/open-event-server that referenced this pull request Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add details for admin invoice billing

5 participants