Skip to content

fix: set public profile name after login #7892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Oct 8, 2021
Merged

fix: set public profile name after login #7892

merged 27 commits into from
Oct 8, 2021

Conversation

@maze-runnar
Copy link
Contributor

@maze-runnar maze-runnar commented Oct 6, 2021

Fixes #7593

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

maze-runnar added 20 commits July 26, 2021 20:45
@maze-runnar
adding frontend ans server version on admin page
6a6066e
@maze-runnar
f
e62e06c
@maze-runnar
revert
d6a481a
@maze-runnar
Merge branch 'development' of https://github.com/fossasia/open-event-…
f6a3248 
…frontend into development
@maze-runnar
Merge branch 'development' of https://github.com/fossasia/open-event-…
24c9237 
…frontend into development
@maze-runnar
Merge branch 'development' of https://github.com/fossasia/open-event-…
1bef0e9 
…frontend into development
@maze-runnar
Merge branch 'development' of https://github.com/fossasia/open-event-…
b8df450 
…frontend into development
@maze-runnar
rebaes
fadde90
@maze-runnar
Merge branch 'development' of https://github.com/fossasia/open-event-…
c843d1a 
…frontend into development
@maze-runnar
Merge branch 'development' of https://github.com/fossasia/open-event-…
a3e2f13 
…frontend into development
@maze-runnar
Rebase ...
a96cea4
@maze-runnar
Merge branch
a8b1486
@maze-runnar
Merge branch 'development' of https://github.com/fossasia/open-event-…
5872f84 
…frontend into development
@maze-runnar
Merge branch 'development' of https://github.com/fossasia/open-event-…
9cbe269 
…frontend into development
@maze-runnar
Rebase not working..
73432de
@maze-runnar
Merge branch 'development' of https://github.com/fossasia/open-event-…
ccee328 
…frontend into development
@maze-runnar
Merge branch 'development' of https://github.com/fossasia/open-event-…
dc8709b 
…frontend into development
@maze-runnar
Merge branch 'development' of https://github.com/fossasia/open-event-…
e108eba 
…frontend into development
@maze-runnar
set public profile name after login
e1909fc
@maze-runnar
set public profile name after login
bdcd5e8
@auto-label auto-label bot added the fix label Oct 6, 2021
@vercel
Copy link

vercel bot commented Oct 6, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/2ssNfnnfp4ShRCzJ65m8wdfg5woB
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-userpr-c61093-eventyay.vercel.app

@maze-runnar
Copy link
Contributor Author

maze-runnar commented Oct 6, 2021

@pc-beast @progmatic-99 please test this. It's complete from my side.

pavnesh-c
pavnesh-c reviewed Oct 6, 2021
View reviewed changes
app/templates/components/forms/user-profile-form.hbs Outdated
@tagName="i"
@class="info circle icon"
@content={{'Public profile name, if set, is displayed to other users on profiles and video sessions instead of real name.'}} />
@content={{'.. instead of a fantasy name.'}} />
Copy link
Member

@pavnesh-c pavnesh-c Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just need to replace "real" with "fantasy" keeping the sentence intact. 🤔

Copy link
Contributor Author

@maze-runnar maze-runnar Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this too 😄

Copy link
Member

@pavnesh-c pavnesh-c Oct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This got reverted.

@pavnesh-c
Copy link
Member

pavnesh-c commented Oct 6, 2021

Code works! 🔥 I was thinking of this approach. But that would have made the authentication system too complex. We don't want that.

pavnesh-c
pavnesh-c previously approved these changes Oct 6, 2021
View reviewed changes
@maze-runnar maze-runnar marked this pull request as draft October 6, 2021 16:06
@codecov
Copy link

codecov bot commented Oct 6, 2021 •
edited
Loading

Codecov Report

Merging #7892 (53b754d) into development (9425f0b) will increase coverage by 0.01%.
The diff coverage is 25.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7892      +/-   ##
===============================================
+ Coverage        18.49%   18.50%   +0.01%     
===============================================
  Files              615      615              
  Lines             7250     7262      +12     
  Branches           149      149              
===============================================
+ Hits              1341     1344       +3     
- Misses            5882     5891       +9     
  Partials            27       27
Impacted Files Coverage Δ
app/components/modals/confirm-modal.js 0.00% <0.00%> (ø)
app/helpers/confirm.js 12.50% <0.00%> (-2.89%) ⬇️
app/routes/index.js 85.71% <50.00%> (-9.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9425f0b...53b754d. Read the comment docs.

@maze-runnar maze-runnar marked this pull request as ready for review October 7, 2021 02:25
@maze-runnar
Copy link
Contributor Author

maze-runnar commented Oct 7, 2021

@mariobehling @pc-beast I have fixed tests, can you please test it again.

@maze-runnar
Copy link
Contributor Author

maze-runnar commented Oct 7, 2021

Screenshot from 2021-10-07 19-18-52

@maze-runnar
Copy link
Contributor Author

maze-runnar commented Oct 8, 2021

@mariobehling please review and merge

@mariobehling mariobehling merged commit 989b518 into fossasia:development Oct 8, 2021
@maze-runnar maze-runnar deleted the userprofile-name branch November 1, 2021 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavnesh-c pavnesh-c pavnesh-c left review comments

@mariobehling mariobehling mariobehling approved these changes

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Show "Set Public Profile Name" Pop up for users without a public profile name after login

3 participants

@maze-runnar @pavnesh-c @mariobehling