fix: public url under admin groups list #7854
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/5jAeeX5Ac62gCwFuaP5uKZgKYMmk |
Codecov Report
@@ Coverage Diff @@
## development #7854 +/- ##
===============================================
- Coverage 18.59% 18.55% -0.05%
===============================================
Files 614 614
Lines 7206 7206
Branches 149 149
===============================================
- Hits 1340 1337 -3
- Misses 5839 5842 +3
Partials 27 27
Continue to review full report at Codecov.
|
divyamtayal
left a comment
divyamtayal
left a comment
There was a problem hiding this comment.
Please fix the indentation
|
double quotes should be changed to single quotes, too?? |
Yes |
progmatic-99
force-pushed
the
fix-7851
branch
from
4fa498e to
558d015
Compare
app/models/group.js
Outdated
| import { belongsTo, hasMany } from 'ember-data/relationships'; | ||
| import { computed } from '@ember/object'; | ||
| import { inject as service } from '@ember/service'; | ||
| import attr from "ember-data/attr"; |
app/models/group.js
Outdated
| import { inject as service } from "@ember/service"; | ||
|
|
||
| export default class Group extends ModelBase.extend({ | ||
| router: service(), |
app/models/group.js
Outdated
| deletedAt : attr('moment'), | ||
| followerCount : attr('number'), | ||
| socialLinks : attr(), | ||
| name: attr("string"), |
app/models/group.js
Outdated
| roles : hasMany('users-groups-role'), | ||
| follower : belongsTo('user-follow-group', { inverse: 'group' }), | ||
| followers : hasMany('user-follow-group'), | ||
| user: belongsTo("user"), |
app/models/group.js
Outdated
| return origin + this.router.urlFor('groups.edit.events', this.id); | ||
| }) | ||
| url: computed("identifier", function () { | ||
| const origin = this.fastboot.isFastBoot |
| const origin = this.fastboot.isFastBoot | ||
| ? `${this.fastboot.request.protocol}//${this.fastboot.request.host}` | ||
| : location.origin; | ||
| return origin + `/g/${this.id}`; |
There was a problem hiding this comment.
@progmatic-99
What I see is that only this line is been modified in this PR. Pls revert other indent changes back to normal.
and pls disable any auto-format extention that might have installed in your code-editor to avoid this small indent issues.
There was a problem hiding this comment.
This is more readable. I will change other things.
progmatic-99
force-pushed
the
fix-7851
branch
from
558d015 to
7ab5269
Compare
4 participants
Fixes #7851