Skip to content

fix: public url under admin groups list #7854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2021
Merged

fix: public url under admin groups list #7854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/group.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export default class Group extends ModelBase.extend({

url: computed('identifier', function() {
const origin = this.fastboot.isFastBoot ? `${this.fastboot.request.protocol}//${this.fastboot.request.host}` : location.origin;
return origin + this.router.urlFor('groups.edit.events', this.id);
return origin + `/g/${this.id}`;
Copy link
Member

@divyamtayal divyamtayal Sep 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@progmatic-99
What I see is that only this line is been modified in this PR. Pls revert other indent changes back to normal.
and pls disable any auto-format extention that might have installed in your code-editor to avoid this small indent issues.

Copy link
Contributor Author

@progmatic-99 progmatic-99 Sep 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more readable. I will change other things.

})
}) {}