Skip to content

Conversation

@ranjitkshah
Copy link
Member

@ranjitkshah ranjitkshah commented Jan 8, 2021

Fixes #5921

Short description of what this resolves:

self-explanatory and referring comment

screenshot:

image

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Jan 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/3b75mokgj
✅ Preview: https://open-event-frontend-git-fork-ranjitkshah-issue-5921.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #6283 (6736846) into development (e80344a) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6283      +/-   ##
===============================================
- Coverage        22.03%   21.97%   -0.07%     
===============================================
  Files              543      543              
  Lines             6041     6044       +3     
  Branches           126      126              
===============================================
- Hits              1331     1328       -3     
- Misses            4684     4690       +6     
  Partials            26       26              
Impacted Files Coverage Δ
app/components/explore/side-bar.js 11.49% <0.00%> (-0.14%) ⬇️
app/routes/explore.js 47.36% <0.00%> (-1.73%) ⬇️
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e80344a...6736846. Read the comment docs.

@ranjitkshah
Copy link
Member Author

@iamareebjamal @sachinchauhan2889 pls review

Copy link
Member

@MeghalBisht MeghalBisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filters work for me, what I found missing is -

  1. By default tick "All Upcoming" and when ticking "All Upcoming" tick "Today" and all other future filters (except custom dates)
  2. "All dates" -> move it to the end of the search filter area
  3. Show "Past" at the end of the widget before "All dates"

@ranjitkshah
Copy link
Member Author

ranjitkshah commented Jan 10, 2021

Thank you for reviewing my PR,

  1. "All dates" -> move it to the end of the search filter area
  2. Show "Past" at the end of the widget before "All dates"

done

  1. By default tick "All Upcoming" and when ticking "All Upcoming" tick "Today" and all other future filters (except custom dates)

facing an issue. currently, when we type in the search box it shows all upcoming but when the route is only "/explore" it shows from a specific date (oct). any suggestion or guidance

@ranjitkshah
Copy link
Member Author

updated screenshot -
image

@mariobehling
Copy link
Member

I think it would be best if you participate in the next meeting. The default search already does the correct behavior, but the UI does not portray the default behavior. For example does the search cover all events for tomorrow? Yes, but in your changes you only show "Upcoming". Tomorrow is a part of upcoming, but you do not show it. Difficult to explain every single point here. You should try to understand the intention of the logic.

@mariobehling
Copy link
Member

If you did understand the logic, then it is not implemented yet as it appears for me as below.

Screenshot from 2021-01-30 20-09-29

@ranjitkshah ranjitkshah changed the title fix: all date filter and upcoming filter fix: all date filter Feb 4, 2021
@ranjitkshah
Copy link
Member Author

now only All date filter is fixed in this PR. @iamareebjamal, please review

@iamareebjamal iamareebjamal merged commit b906654 into fossasia:development Feb 5, 2021
@ranjitkshah ranjitkshah deleted the issue-5921 branch February 5, 2021 05:50
MeghalBisht pushed a commit to MeghalBisht/open-event-frontend that referenced this pull request Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search: Fix and Enhance filter options

4 participants