-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: all date filter #6283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: all date filter #6283
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/3b75mokgj |
Codecov Report
@@ Coverage Diff @@
## development #6283 +/- ##
===============================================
- Coverage 22.03% 21.97% -0.07%
===============================================
Files 543 543
Lines 6041 6044 +3
Branches 126 126
===============================================
- Hits 1331 1328 -3
- Misses 4684 4690 +6
Partials 26 26
Continue to review full report at Codecov.
|
|
@iamareebjamal @sachinchauhan2889 pls review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filters work for me, what I found missing is -
- By default tick "All Upcoming" and when ticking "All Upcoming" tick "Today" and all other future filters (except custom dates)
- "All dates" -> move it to the end of the search filter area
- Show "Past" at the end of the widget before "All dates"
|
Thank you for reviewing my PR,
done
facing an issue. currently, when we type in the search box it shows all upcoming but when the route is only "/explore" it shows from a specific date (oct). any suggestion or guidance |
071f7f3 to
b072e8b
Compare
|
I think it would be best if you participate in the next meeting. The default search already does the correct behavior, but the UI does not portray the default behavior. For example does the search cover all events for tomorrow? Yes, but in your changes you only show "Upcoming". Tomorrow is a part of upcoming, but you do not show it. Difficult to explain every single point here. You should try to understand the intention of the logic. |
|
now only |


Fixes #5921
Short description of what this resolves:
self-explanatory and referring comment
screenshot:
Checklist
developmentbranch.