Skip to content

fix: pagination page size in message list #6254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 8, 2021
Merged

fix: pagination page size in message list #6254

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
edb3ec1
just
maze-runnar Jan 6, 2021
dda703c
usual
maze-runnar Jan 6, 2021
7a6ee67
removed added messages
maze-runnar Jan 8, 2021
b088bb0
hiding search box for now
maze-runnar Jan 8, 2021
f359183
fix
maze-runnar Jan 8, 2021
34a5d36
reverting with modification
maze-runnar Jan 8, 2021
7f8d58f
ui
maze-runnar Jan 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/routes/admin/messages/list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ export default class extends Route.extend(EmberTableRouteMixin) {
const searchField = 'recipient';
const filterOptions = this.applySearchFilters([], params, searchField);
let queryString = {
filter : filterOptions,
'page[size]' : params.per_page || 100,
'page[number' : params.page || 1
filter : filterOptions,
'page[size]' : params.per_page || 100,
'page[number]' : params.page || 1
Copy link
Member

@iamareebjamal iamareebjamal Jan 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this change?

Copy link
Contributor Author

@maze-runnar maze-runnar Jan 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking into #3693 then I found the wrong syntax page[number

Copy link
Contributor Author

@maze-runnar maze-runnar Jan 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem with #3693 is due to wrong passing of querystring. I have some doubts regarding that to discuss in technical meeting.

};
queryString = this.applySortFilters(queryString, params);
return this.asArray(this.modelFor('admin.messages', queryString));
Copy link
Contributor Author

@maze-runnar maze-runnar Jan 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the queryString should be in 'admin.messeges' with page[size] and page[number]. But how to pass it there?

Expand Down