Skip to content

Conversation

@maze-runnar
Copy link
Contributor

related #3693

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Jan 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/dvnhem688
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-unusual-find.eventyay.vercel.app

'page[number' : params.page || 1
filter : filterOptions,
'page[size]' : params.per_page || 100,
'page[number]' : params.page || 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking into #3693 then I found the wrong syntax page[number

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem with #3693 is due to wrong passing of querystring. I have some doubts regarding that to discuss in technical meeting.

@auto-label auto-label bot added the fix label Jan 6, 2021
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #6254 (7f8d58f) into development (b946be0) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6254   +/-   ##
============================================
  Coverage        22.57%   22.58%           
============================================
  Files              523      519    -4     
  Lines             5715     5704   -11     
  Branches           111      112    +1     
============================================
- Hits              1290     1288    -2     
+ Misses            4398     4389    -9     
  Partials            27       27           
Impacted Files Coverage Δ
app/controllers/admin/messages.js 0.00% <0.00%> (ø)
app/router.js 100.00% <ø> (ø)
app/routes/admin/messages.js 0.00% <0.00%> (ø)
app/models/event.js 15.78% <0.00%> (-0.88%) ⬇️
app/components/public/stream/side-panel.ts 3.22% <0.00%> (-0.23%) ⬇️
app/components/public/side-menu.js 0.00% <0.00%> (ø)
app/controllers/events/view/scheduler.js 0.00% <0.00%> (ø)
...pp/routes/events/view/tickets/access-codes/list.js 0.00% <0.00%> (ø)
app/controllers/public/schedule.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b946be0...7f8d58f. Read the comment docs.

'page[number]' : params.page || 1
};
queryString = this.applySortFilters(queryString, params);
return this.asArray(this.modelFor('admin.messages', queryString));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the queryString should be in 'admin.messeges' with page[size] and page[number]. But how to pass it there?

@maze-runnar
Copy link
Contributor Author

maze-runnar commented Jan 8, 2021

I am getting this empy table after moving mesages/list to mesages and deleting it. Event it is returning everything in response.
Screenshot from 2021-01-08 09-27-46

@maze-runnar
Copy link
Contributor Author

the above is fixed, but sorting and searching is giving error.

@maze-runnar
Copy link
Contributor Author

{"errors": [{"status": 400, "source": {"parameter": "filters"}, "title": "Invalid filters querystring parameter.", "detail": "MessageSettings has no attribute recipient"}], "jsonapi": {"version": "1.0"}}

@iamareebjamal
Copy link
Member

Push the changes, or else how will I debug?

@iamareebjamal
Copy link
Member

iamareebjamal commented Jan 8, 2021

See Message Setting model in server and remove sortable/searchable from all fields which are not in model, like recipient

@maze-runnar
Copy link
Contributor Author

I have removed recipient and now ony sent_at is sortable. And there is no other field that can be make searchable. So I hid the searchbox.

@iamareebjamal
Copy link
Member

Is the save button necessary?

@maze-runnar
Copy link
Contributor Author

Is the save button necessary?

I think no, it's not working right now or it shouldn't be there.

@iamareebjamal
Copy link
Member

It should not be removed if it was saving the settings, please restore but put it in a proper place

@maze-runnar
Copy link
Contributor Author

It should not be removed if it was saving the settings, please restore but put it in a proper place

but it's not saving settings actually. they are kind of fixed. On server side the setting is implemented as

def create_admin_message_settings():
    default_mails = [
        "Next Event",
        "Session Schedule Change",
        "User email",
        "Invitation For Papers",
        "After Event",
        "Ticket(s) Purchased",
        "Session State Change",
        "Event Published",
        "Event Export Failed",
        "Event Exported",
        "Event Role Invitation",
        "New Session Proposal",
    ]
    for mail in MAILS:
        if mail in default_mails:
            get_or_create(
                MessageSettings,
                action=mail,
                mail_status=True,
                notification_status=True,
                user_control_status=True,
            )
        else:
            get_or_create(
                MessageSettings,
                action=mail,
                mail_status=False,
                notification_status=False,
                user_control_status=False,
            )

@maze-runnar
Copy link
Contributor Author

so on refreshing page the settings are set to previous(the above values), no matter they are saved whatever

@iamareebjamal
Copy link
Member

But notification and mail status are editable

@maze-runnar
Copy link
Contributor Author

reverted

@iamareebjamal
Copy link
Member

Move save to right and add padding top

@maze-runnar
Copy link
Contributor Author

is it ok?
Screenshot from 2021-01-08 17-05-59

@iamareebjamal iamareebjamal merged commit 2e32e93 into fossasia:development Jan 8, 2021
@maze-runnar maze-runnar deleted the unusual-find branch January 25, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants