Skip to content

fix: show speaker in menu when speker is available #5121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: show speaker in menu when speker is available #5121

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acc459e
check speaker avail after session confirmed
maze-runnar Sep 22, 2020
7ecbcf0
tried many things, not worked, using speaker.length in last
maze-runnar Sep 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/components/public/side-menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import classic from 'ember-classic-decorator';
import { action, computed } from '@ember/object';
import Component from '@ember/component';
import moment from 'moment';
import { SPEAKERS_FILTER } from 'open-event-frontend/routes/public/speakers';
import { tracked } from '@glimmer/tracking';

@classic
Expand All @@ -24,7 +23,7 @@ export default class SideMenu extends Component {
}

async checkSpeakers() {
this.showSpeakers = this.showSpeakers || (await this.loader.load(`/events/${this.event.id}/speakers?fields[speaker]=id&page[size]=1&filters=${JSON.stringify(SPEAKERS_FILTER)}`)).data.length;
this.showSpeakers = this.showSpeakers || this.event.speakers.length;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said, this is not a good idea as it loads all speakers in one go. Secndly, it does not filter the speakers who have no accepted or confirmed sessions. It was used for a reason

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying to figure out why it's happening there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://api.eventyay.com//v1/events/1211/speakers and https://api.eventyay.com//v1/events/5ac8e4d9/speakers they both are on same page.
first one is returning empty response and second is giving response

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There must be some discrepancies in filters used

}

async checkSessions() {
Expand Down