fix: show speaker in menu when speker is available

[maze-runnar]

Fixes #4999

Checklist

• I have read the Contribution & Best practices Guide.
• My branch is up-to-date with the Upstream development branch.
• The acceptance, integration, unit tests and linter pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/1txfq5dp5
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-showspeaker.eventyay.vercel.app

[mariobehling]

Yes, good. I see the speakers link is no longer in the sidebar.

The speakers page should also not exist or not be accessible if there is no speaker, e.g. https://open-event-frontend-git-fork-maze-runnar-showspeaker.eventyay.vercel.app/e/5ac8e4d9/speakers

[maze-runnar]

The speakers page should also not exist or not be accessible

@iamareebjamal how to do it? No such feature is avail for /schedule or /calendar is available on event page.

[iamareebjamal]

This is not good. Now it'll load speakers on the index page itself. Check the problem in showSpeakers and fix that instead

[iamareebjamal]

Same here

[codecov]

Codecov Report

Merging #5121 into development will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development    #5121   +/-   ##
============================================
  Coverage        22.80%   22.80%           
============================================
  Files              489      489           
  Lines             5169     5169           
  Branches            35       35           
============================================
  Hits              1179     1179           
  Misses            3985     3985           
  Partials             5        5           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 513506e...acc459e. Read the comment docs.

[maze-runnar]

await this.loader.load(/events/${this.event.id}/speakers?fields[speaker]=id&page[size]=1&filters=${JSON.stringify(SPEAKERS_FILTER)})).data.length

in this condition the above code is not working. even Schedule is not showing in side tab due to isSchedulePublished condition, showSession is not working AS expected there too.

[maze-runnar]

can I use isSessionScheduled in Speaker Section too?

[maze-runnar]

await this.loader.load(/events/${this.event.id}/speakers?fields[speaker]=id&page[size]=1&filters=${JSON.stringify(SPEAKERS_FILTER)})).data.length > 1

[iamareebjamal]

As I said, this is not a good idea as it loads all speakers in one go. Secndly, it does not filter the speakers who have no accepted or confirmed sessions. It was used for a reason

[maze-runnar]

trying to figure out why it's happening there.

[maze-runnar]

https://api.eventyay.com//v1/events/1211/speakers and https://api.eventyay.com//v1/events/5ac8e4d9/speakers they both are on same page.
first one is returning empty response and second is giving response

[iamareebjamal]

There must be some discrepancies in filters used

[iamareebjamal]

Superseded by #5171