Skip to content

fix: minOrder-maxOrder & minPrice-maxPrice validation in basic-details-step #3849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2020
Merged

fix: minOrder-maxOrder & minPrice-maxPrice validation in basic-details-step #3849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions app/components/forms/wizard/basic-details-step.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { inject as service } from '@ember/service';
import EventWizardMixin from 'open-event-frontend/mixins/event-wizard';
import { protocolLessValidUrlPattern } from 'open-event-frontend/utils/validators';
import ENV from 'open-event-frontend/config/environment';
import $ from 'jquery';

export default Component.extend(FormMixin, EventWizardMixin, {

Expand Down Expand Up @@ -128,6 +129,12 @@ export default Component.extend(FormMixin, EventWizardMixin, {

// TODO: Removing the Event Time Validations due to the weird and buggy behaviour. Will be restored once a perfect solution is found. Please check issue: https://github.com/fossasia/open-event-frontend/issues/3667
getValidationRules() {
$.fn.form.settings.rules.checkMaxMinPrice = () => {
return $('.ui.form').form('get value', 'min_price') <= $('.ui.form').form('get value', 'max_price');
};
$.fn.form.settings.rules.checkMaxMinOrder = () => {
return $('.ui.form').form('get value', 'ticket_min_order') <= $('.ui.form').form('get value', 'ticket_max_order');
};

let validationRules = {
inline : true,
Expand Down Expand Up @@ -257,6 +264,10 @@ export default Component.extend(FormMixin, EventWizardMixin, {
{
type : 'number',
prompt : this.l10n.t('Invalid number')
},
{
type : 'checkMaxMinOrder',
prompt : this.l10n.t('Minimum order should not be greater than maximum')
}
]
},
Expand All @@ -274,6 +285,10 @@ export default Component.extend(FormMixin, EventWizardMixin, {
{
type : 'integer[1..]',
prompt : this.l10n.t('Maximum tickets per order should be greater than 0')
},
{
type : 'checkMaxMinOrder',
prompt : this.l10n.t('Maximum order should not be less than minimum')
}
]
},
Expand All @@ -287,6 +302,10 @@ export default Component.extend(FormMixin, EventWizardMixin, {
{
type : 'integer[1..]',
prompt : this.l10n.t('Minimum price needs to be greater than zero')
},
{
type : 'checkMaxMinPrice',
prompt : this.l10n.t('Minimum price should not be greater than maximum')
}
]
},
Expand All @@ -300,6 +319,10 @@ export default Component.extend(FormMixin, EventWizardMixin, {
{
type : 'integer[1..]',
prompt : this.l10n.t('Maximum price needs to be greater than zero')
},
{
type : 'checkMaxMinPrice',
prompt : this.l10n.t('Maximum price should not be less than minimum')
}
]
},
Expand Down