fix: minOrder-maxOrder & minPrice-maxPrice validation in basic-details-step #3849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushthedude
reviewed
Jan 29, 2020
| window.$.fn.form.settings.rules.checkMaxMinOrder = () => { | ||
| return this.$('.ui.form').form('get value', 'ticket_min_order') <= this.$('.ui.form').form('get value', 'ticket_max_order'); | ||
| }; | ||
| window.$.fn.form.settings.rules.checkMaxTotal = () => { |
There was a problem hiding this comment.
Check if server validations are present for them or not.
If not then first server validations need to be added then the FE
There was a problem hiding this comment.
@kushthedude Yes the server validations are already persent.
Codecov Report
@@ Coverage Diff @@
## development #3849 +/- ##
===============================================
+ Coverage 21.83% 21.86% +0.02%
===============================================
Files 460 460
Lines 4726 4730 +4
===============================================
+ Hits 1032 1034 +2
- Misses 3694 3696 +2
Continue to review full report at Codecov.
|
iamareebjamal
approved these changes
Feb 6, 2020
iamareebjamal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3521
Short description of what this resolves:
Added minOrder-maxOrder & minPrice-maxPrice validation in ticket-input.
(Server checks are already present.)
Changes proposed in this pull request: